There are 2 metrics already captured in the push server metrics endpoint. More info here https://github.com/aerogear/aerogear-unifiedpush-server/pull/949 Related trello with more info on the story [1] I'm interested in any suggestions on what else could/should be included in the metrics endpoint. CPU/RAM will already be captured by heapster in openshift Any thoughts on using the same approach as keycloak & including default exports https://github.com/prometheus/client_java#included-collectors https://github.com/aerogear/keycloak-metrics-spi/blob/ master/src/main/java/org/jboss/aerogear/keycloak/ metrics/PrometheusExporter.java#L55 ? Is there anything else specific to administering a push server that would be useful? [1] https://trello.com/c/tPin7vee/22-as-a-developer-i- want-to-be-able-to-expose-metrics-data-about-push-in- prometheus-format-from-an-endpoint-of-this-service -- David Martin Red Hat Mobile Twitter: @irldavem IRC: @irldavem (#aerogear) _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

I think it would be a good idea to have pinpoint as well. Il 22 Gen 2018 12:29 PM, "Matthias Wessendorf" <matzew(a)apache.org&gt; ha scritto: > +1 on DefaultExports usage > > On Mon, Jan 22, 2018 at 11:43 AM, David Martin <davmarti(a)redhat.com&gt; > wrote: > >> There are 2 metrics already captured in the push server metrics endpoint. >> More info here >> https://github.com/aerogear/aerogear-unifiedpush-server/pull/949 >> Related trello with more info on the story [1] >> >> >> I'm interested in any suggestions on what else could/should be included >> in the metrics endpoint. >> >> CPU/RAM will already be captured by heapster in openshift >> >> Any thoughts on using the same approach as keycloak & including default >> exports >> https://github.com/prometheus/client_java#included-collectors >> https://github.com/aerogear/keycloak-metrics-spi/blob/master >> /src/main/java/org/jboss/aerogear/keycloak/metrics/Prometheu >> sExporter.java#L55 >> ? >> >> Is there anything else specific to administering a push server that >> would be useful? >> >> [1] https://trello.com/c/tPin7vee/22-as-a-developer-i-want-t >> o-be-able-to-expose-metrics-data-about-push-in-prometheus-fo >> rmat-from-an-endpoint-of-this-service >> -- >> David Martin >> Red Hat Mobile >> Twitter: @irldavem >> IRC: @irldavem (#aerogear) >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> > > > > -- > Matthias Wessendorf > > github: https://github.com/matzew > twitter: http://twitter.com/mwessendorf > > _______________________________________________ > feedhenry-dev mailing list > feedhenry-dev(a)redhat.com > https://www.redhat.com/mailman/listinfo/feedhenry-dev > > _______________________________________________ feedhenry-dev mailing list feedhenry-dev(a)redhat.com https://www.redhat.com/mailman/listinfo/feedhenry-dev

One of the captured metrics is ‚push_requests_total‘. It would be nice to add a label here to group by platform, e.g. ‚push_requests_total{platform=„android“} = 5.0‘

About the default metrics. They are free and i think we should include them just to have the same behavior in our metrics endpoints as much as possible.

Am 22.01.2018 um 11:43 schrieb David Martin <davmarti(a)redhat.com&gt;: There are 2 metrics already captured in the push server metrics endpoint. More info here https://github.com/aerogear/aerogear-unifiedpush-server/pull/949 Related trello with more info on the story [1] I'm interested in any suggestions on what else could/should be included in the metrics endpoint. CPU/RAM will already be captured by heapster in openshift Any thoughts on using the same approach as keycloak & including default exports https://github.com/prometheus/client_java#included-collectors https://github.com/aerogear/keycloak-metrics-spi/blob/ master/src/main/java/org/jboss/aerogear/keycloak/ metrics/PrometheusExporter.java#L55 ? Is there anything else specific to administering a push server that would be useful? [1] https://trello.com/c/tPin7vee/22-as-a-developer-i- want-to-be-able-to-expose-metrics-data-about-push-in- prometheus-format-from-an-endpoint-of-this-service -- David Martin Red Hat Mobile Twitter: @irldavem IRC: @irldavem (#aerogear) _______________________________________________ feedhenry-dev mailing list feedhenry-dev(a)redhat.com https://www.redhat.com/mailman/listinfo/feedhenry-dev _______________________________________________ feedhenry-dev mailing list feedhenry-dev(a)redhat.com https://www.redhat.com/mailman/listinfo/feedhenry-dev