July 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-4890) Adapt calls to RootGraph#appliesTo() to Hibernate ORM 6.3

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiNGY5OTli... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-4890?atlOrigin=eyJpIjoiNGY... ) HSEARCH-4890 ( https://hibernate.atlassian.net/browse/HSEARCH-4890?atlOrigin=eyJpIjoiNGY... ) Adapt calls to RootGraph#appliesTo() to Hibernate ORM 6.3 ( https://hibernate.atlassian.net/browse/HSEARCH-4890?atlOrigin=eyJpIjoiNGY... ) Issue Type: Task Assignee: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: mapper-orm Created: 03/Jul/2023 00:36 AM Fix Versions: 6.2.0.Final, 7.0.0.Beta1 Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) ORM 6.3 is changing that (incubating) SPI, so we need to adapt to stay compatible. Using this code instead of calling appliesTo should be fine: final ManagedDomainType<J> managedTypeDescriptor = getGraphedType(); if ( managedTypeDescriptor.equals( entityType ) ) { return true; } IdentifiableDomainType<?> superType = entityType.getSupertype(); while ( superType != null ) { if ( managedTypeDescriptor.equals( superType ) ) { return true; } superType = superType.getSupertype(); } return false; ( https://hibernate.atlassian.net/browse/HSEARCH-4890#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4890#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HHH-16845) cached entity with @EmbeddedId cannot use @ElementCollection

by Michael Kroll (JIRA)

Michael Kroll ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=62ea4af... ) *commented* on HHH-16845 ( https://hibernate.atlassian.net/browse/HHH-16845?atlOrigin=eyJpIjoiNTQ3MG... ) Re: cached entity with @EmbeddedId cannot use @ElementCollection ( https://hibernate.atlassian.net/browse/HHH-16845?atlOrigin=eyJpIjoiNTQ3MG... ) I would be interested in that, too. This bug brings JakartaEE migration to a grinding halt. ( https://hibernate.atlassian.net/browse/HHH-16845#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16845#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HSEARCH-4889) Forbid usage of internal/incubating Hibernate ORM code (API/SPI/...)

by Marko Bekhta (JIRA)

Marko Bekhta ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-4889 ( https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiZjA... ) Re: Forbid usage of internal/incubating Hibernate ORM code (API/SPI/...) ( https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiZjA... ) Just gave the forbiddenapis a quick try: Parsing signatures failed: Field not found while parsing signature: org.hibernate.boot.model.TypeContributions#contributeAttributeConverter 😔, so we probably would need to go with jqassistant. ( https://hibernate.atlassian.net/browse/HSEARCH-4889#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4889#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HSEARCH-4889) Forbid usage of internal/incubating Hibernate ORM code (API/SPI/...)

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiODQ2ZTJl... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiODQ... ) HSEARCH-4889 ( https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiODQ... ) Forbid usage of internal/incubating Hibernate ORM code (API/SPI/...) ( https://hibernate.atlassian.net/browse/HSEARCH-4889?atlOrigin=eyJpIjoiODQ... ) Issue Type: Task Assignee: Unassigned Components: build Created: 03/Jul/2023 00:06 AM Fix Versions: 7.0-backlog Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) See https://hibernate.zulipchat.com/#narrow/stream/132084-redhat-specific/top... , such code is not safe to use if we want to preserve compatibility across more than one ORM version. ORM annotates packages/classes/methods with custom annotations to warn about incupating/internal/deprecated methods. Unfortunately We could probably take advantage of JQAssistant to forbid usage of such code, like we already do for implementation leaks inside Hibernate Search APIs. Getting method/field granularity might be annoying, though. Alternatively, we might be able to feed reports generated by Hibernate ORM to forbiddenapis: * https://docs.jboss.org/hibernate/orm/6.2/deprecated/deprecating.txt * https://docs.jboss.org/hibernate/orm/6.2/incubating/incubating.txt * https://docs.jboss.org/hibernate/orm/6.2/internals/internal.txt I’m not sure the format is compatible though; the type of method parameters seems to be missing, and I believe forbiddenapis requires that. I may be wrong though; we need to check. ( https://hibernate.atlassian.net/browse/HSEARCH-4889#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4889#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HHH-16881) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled

by Manuel Garcia de Vinuesa (JIRA)

Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNTRmMzhjZTU5... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiNTRmMz... ) HHH-16881 ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiNTRmMz... ) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiNTRmMz... ) Change By: Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) From Hibernate 6.2 it is mandatory enabled CDI extensions to work with Spring Container, this is included in Spring 3.1 in the class {{HibernateJpaVendorAdapter}} (spring-orm). !image-20230703-065313.png|width=526,height=65! The problem it is in the class {{DefaultRevisionInfoGenerator}} (hibernate-envers) when the method {{resolveRevisionListenerBean}}. The condition {{Helper.allowExtensionsInCdi( serviceRegistry )}}should be negated to allow use Spring Container. {code:java}private ManagedBean<? extends RevisionListener> resolveRevisionListenerBean( Class<? extends RevisionListener> listenerClass, ServiceRegistry serviceRegistry) { if ( !listenerClass.equals( RevisionListener.class ) ) { if ( Helper.allowExtensionsInCdi( serviceRegistry ) ) { return new ProvidedInstanceManagedBeanImpl<>( FallbackBeanInstanceProducer.INSTANCE.produceBeanInstance( listenerClass ) ); } return serviceRegistry.getService( ManagedBeanRegistry.class ).getBean( listenerClass ); } return null; } {code} To reproduce you (@Chris Cranford) can use your demo (I just forked) to test it, [mgvinuesa/hibernate-envers-spring: A demo of how to wire Spring Framework 5.1+ to inject beans into Hibernate Envers RevisionListener (github.com)|https://github.com/mgvinuesa/hibernate-envers-spring] If you change the spring boot version to 3.0, everything works properly, but when it is updated to 3.1, the RevisionListener does not work properly and you could see in the log the following message: {noformat}MyService was not injected.{noformat} ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HHH-16642) Treated join in subquery results in invalid SQL

by Marco Belladelli (JIRA)

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HHH-16881) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled

by Manuel Garcia de Vinuesa (JIRA)

Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNTNhZDdhMjU4... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiNTNhZD... ) HHH-16881 ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiNTNhZD... ) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiNTNhZD... ) Change By: Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) From Hibernate 6.2 it is mandatory enabled CDI extensions to work with Spring Container, this is included in Spring 3.1 in the class {{HibernateJpaVendorAdapter}} (spring-orm). !image-20230703-065313.png|width=526,height=65! The problem it is in the class {{DefaultRevisionInfoGenerator}} (hibernate-envers) when the method {{resolveRevisionListenerBean}}. The condition {{Helper.allowExtensionsInCdi( serviceRegistry )}}should be negated to allow use Spring Container. {code:java}private ManagedBean<? extends RevisionListener> resolveRevisionListenerBean( Class<? extends RevisionListener> listenerClass, ServiceRegistry serviceRegistry) { if ( !listenerClass.equals( RevisionListener.class ) ) { if ( Helper.allowExtensionsInCdi( serviceRegistry ) ) { return new ProvidedInstanceManagedBeanImpl<>( FallbackBeanInstanceProducer.INSTANCE.produceBeanInstance( listenerClass ) ); } return serviceRegistry.getService( ManagedBeanRegistry.class ).getBean( listenerClass ); } return null; } {code} To reproduce you can use my your demo (I just forked) to test it, [mgvinuesa/hibernate-envers-spring: A demo of how to wire Spring Framework 5.1+ to inject beans into Hibernate Envers RevisionListener (github.com)|https://github.com/mgvinuesa/hibernate-envers-spring] If you change the spring boot version to 3.0, everything works properly, but when it is updated to 3.1, the RevisionListener does not work properly and you could see in the log the following message: {noformat}MyService was not injected.{noformat} ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HHH-16881) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled

by Manuel Garcia de Vinuesa (JIRA)

Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMTJiNzBhZWVj... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiMTJiNz... ) HHH-16881 ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiMTJiNz... ) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiMTJiNz... ) Change By: Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) From Hibernate 6.2 it is mandatory enabled CDI extensions to work with Spring Container, this is included in Spring 3.1 in the class {{HibernateJpaVendorAdapter}} (spring-orm). !image-20230703-065313.png|width=526,height=65! The problem it is in the class {{DefaultRevisionInfoGenerator}} (hibernate-envers) when the method {{resolveRevisionListenerBean}}. The condition {{Helper.allowExtensionsInCdi( serviceRegistry )}}should be negated to allow use Spring Container. {code:java}private ManagedBean<? extends RevisionListener> resolveRevisionListenerBean( Class<? extends RevisionListener> listenerClass, ServiceRegistry serviceRegistry) { if ( !listenerClass.equals( RevisionListener.class ) ) { if ( Helper.allowExtensionsInCdi( serviceRegistry ) ) { return new ProvidedInstanceManagedBeanImpl<>( FallbackBeanInstanceProducer.INSTANCE.produceBeanInstance( listenerClass ) ); } return serviceRegistry.getService( ManagedBeanRegistry.class ).getBean( listenerClass ); } return null; } {code} To reproduce you can use my demo to test it, [mgvinuesa/hibernate-envers-spring: A demo of how to wire Spring Framework 5.1+ to inject beans into Hibernate Envers RevisionListener (github.com)|https://github.com/mgvinuesa/hibernate-envers-spring] If you change the spring boot version to 3.0, everything works properly, but when it is updated to 3.1, the RevisionListener does not work properly and you could see in the log the following message: {noformat}MyService was not injected. {noformat} ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HHH-16881) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled

by Manuel Garcia de Vinuesa (JIRA)

Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMDFlZWFmNzFh... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiMDFlZW... ) HHH-16881 ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiMDFlZW... ) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiMDFlZW... ) Change By: Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) From Hibernate 6.2 it is mandatory enabled CDI extensions to work with Spring Container, this is included in Spring 3.1 in the class {{HibernateJpaVendorAdapter}} (spring-orm). !image-20230703-065313.png|width=526,height=65! The problem it is in the class {{DefaultRevisionInfoGenerator}} (hibernate-envers) when the method {{resolveRevisionListenerBean}} it is executed due to the. The condition {{Helper.allowExtensionsInCdi( serviceRegistry )}}should be negated to allow use Spring Container. {code:java}private ManagedBean<? extends RevisionListener> resolveRevisionListenerBean( Class<? extends RevisionListener> listenerClass, ServiceRegistry serviceRegistry) { if ( !listenerClass.equals( RevisionListener.class ) ) { if ( Helper.allowExtensionsInCdi( serviceRegistry ) ) { return new ProvidedInstanceManagedBeanImpl<>( FallbackBeanInstanceProducer.INSTANCE.produceBeanInstance( listenerClass ) ); } return serviceRegistry.getService( ManagedBeanRegistry.class ).getBean( listenerClass ); } return null; } {code} To reproduce you can use my demo to test it, [mgvinuesa/hibernate-envers-spring: A demo of how to wire Spring Framework 5.1+ to inject beans into Hibernate Envers RevisionListener (github.com)|https://github.com/mgvinuesa/hibernate-envers-spring] If you change the spring boot version to 3.0, everything works properly, but when it is updated to 3.1, the RevisionListener does not work properly. ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 3 weeks

1
0
0 / 0

[JIRA] (HHH-16881) Envers RevisionListener is not created when Hibernate CDI Extensions is enabled

by Manuel Garcia de Vinuesa (JIRA)

10 months, 3 weeks

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues July 2023