I appreciate the work that goes into Hibernate and we couldn't do what we do without it. However...
It's irritating that patches such as this one aren't accepted just because there isn't a test case. Especially when there isn't a single unit test for this entire class in the first place! Accepting this patch, even without a test case, would strictly improve the quality of hibernate and it wouldn't take more than 30 seconds to look at this one-liner and arrive at that conclusion.
Hibernate is one of the few third party dependencies that we continue to have to do custom builds for and the continuing unwillingness to take this type of patch is one of the reasons I don't think we'll ever get out of that hole.
Given that you've had my patch for nearly six years I'm not holding my breath on this one. Given that I haven't come back to it in six years to provide a test case, I wouldn't hold my breath for one either.
|