[JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Brenton Leanhardt (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Brenton Leanhardt commented on JBIDE-15830:
-------------------------------------------
How do these tests run? Are these tests run against a particular OpenShift environment?
> openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Labels: openshift-java-client
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim edited comment on JBIDE-15830 at 10/31/13 3:21 PM:
--------------------------------------------------------------------
There are 2 tests in the client that should prevent this from happening:
{code:title=HttpClientTest}
@Test
public void hasProperAgentWhenUsingKeys() throws IOException {
// pre-conditions
UserAgentClientFake clientFake = new UserAgentClientFake("com.needskey");
// operation
HttpURLConnection connection = clientFake.createConnection();
// verification
assertThat(clientFake.getUserAgent(connection)).isEqualTo("OpenShift-com.needskey");
}
@Test
public void hasProperAgentWhenUsingKeysAndNoAgent() throws IOException {
// pre-conditions
UserAgentClientFake clientFake = new UserAgentClientFake(null);
// operation
HttpURLConnection connection = clientFake.createConnection();
// verification
assertThat(clientFake.getUserAgent(connection)).isEqualTo("OpenShift");
}
{code}
I'm wondering how the reported behavior could go unnoticed.
was (Author: adietish):
There are 2 tests in the client that should prevent this from happening:
{code}
@Tes:title=HttpClientTestt
public void hasProperAgentWhenUsingKeys() throws IOException {
// pre-conditions
UserAgentClientFake clientFake = new UserAgentClientFake("com.needskey");
// operation
HttpURLConnection connection = clientFake.createConnection();
// verification
assertThat(clientFake.getUserAgent(connection)).isEqualTo("OpenShift-com.needskey");
}
@Test
public void hasProperAgentWhenUsingKeysAndNoAgent() throws IOException {
// pre-conditions
UserAgentClientFake clientFake = new UserAgentClientFake(null);
// operation
HttpURLConnection connection = clientFake.createConnection();
// verification
assertThat(clientFake.getUserAgent(connection)).isEqualTo("OpenShift");
}
{code}
I'm wondering how the reported behavior could go unnoticed.
> openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Labels: openshift-java-client
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim commented on JBIDE-15830:
------------------------------------------
There are 2 tests in the client that should prevent this from happening:
{code}
@Tes:title=HttpClientTestt
public void hasProperAgentWhenUsingKeys() throws IOException {
// pre-conditions
UserAgentClientFake clientFake = new UserAgentClientFake("com.needskey");
// operation
HttpURLConnection connection = clientFake.createConnection();
// verification
assertThat(clientFake.getUserAgent(connection)).isEqualTo("OpenShift-com.needskey");
}
@Test
public void hasProperAgentWhenUsingKeysAndNoAgent() throws IOException {
// pre-conditions
UserAgentClientFake clientFake = new UserAgentClientFake(null);
// operation
HttpURLConnection connection = clientFake.createConnection();
// verification
assertThat(clientFake.getUserAgent(connection)).isEqualTo("OpenShift");
}
{code}
I'm wondering how the reported behavior could go unnoticed.
> openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15830:
-------------------------------------
Summary: openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin (was: openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin)
> openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15830:
-------------------------------------
Labels: openshift-java. (was: )
> openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Labels: openshift-java.
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15830:
-------------------------------------
Labels: openshift-java-client (was: openshift-java.)
> openshift-java-client: incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Labels: openshift-java-client
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim reassigned JBIDE-15830:
----------------------------------------
Assignee: Andre Dietisheim
> openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15830:
-------------------------------------
Fix Version/s: 4.2.0.Alpha1
> openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Fix For: 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15830) openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
by Andre Dietisheim (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15830?page=com.atlassian.jira.plugi... ]
Andre Dietisheim updated JBIDE-15830:
-------------------------------------
Fix Version/s: 4.1.1.Beta1
> openshift-java-client incompatibility with OpenShift Enterprise and Origin when using the remote-user authentication plugin
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15830
> URL: https://issues.jboss.org/browse/JBIDE-15830
> Project: Tools (JBoss Tools)
> Issue Type: Bug
> Reporter: Brenton Leanhardt
> Assignee: Andre Dietisheim
> Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>
> OpenShift Enterprise and Origin both ship an authentication plugin that allows parts of authentication to be handled by Apache and other parts to be delegated to the openshift-origin-controller codebase. I've found that all versions of openshift-java-client after 2.3.0.Final change a (poorly documented) requirement for the OpenShift remote-user plugin.
> In order for a request to bypass the Apache authentication and passthrough to the OpenShift Broker the user-agent header is inspected. If the user-agent is 'OpenShift' then the Broker will require an encrypted authentication token. Today this is used by the jenkins cartridge but I believe it's also still used for scaling.
> You can see this for details:
> https://github.com/openshift/origin-server/blob/master/documentation/arch...
> In 2.3.0.Final of the openshift-java-client the user-agent was 'OpenShift' however all versions after this set the user-agent to the java version (eg, User-Agent: Java/1.7.0_45).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months
[JBoss JIRA] (JBIDE-15499) Support drag'n'drop of links to "connectors" similar to marketplace to central for auto install
by Snjezana Peco (JIRA)
[ https://issues.jboss.org/browse/JBIDE-15499?page=com.atlassian.jira.plugi... ]
Snjezana Peco commented on JBIDE-15499:
---------------------------------------
Radim, Rastislav,
I suppose you have tried to drop the URL into an empty editor area.
The editor area has its drop target that opens an editor.
There is no easy way to add our target to the editor area. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=248462
The issue happens on Linux and Windows. The difference is that Windows doesn't throw an exception.
If you drop the URL to the toolbar area, menu area, JBoss Central editor, it will work correctly.
Max, Nick,
Do you mean I need to make a fix/workaround for this issue?
> Support drag'n'drop of links to "connectors" similar to marketplace to central for auto install
> -----------------------------------------------------------------------------------------------
>
> Key: JBIDE-15499
> URL: https://issues.jboss.org/browse/JBIDE-15499
> Project: Tools (JBoss Tools)
> Issue Type: Feature Request
> Components: central
> Reporter: Max Rydahl Andersen
> Assignee: Snjezana Peco
> Priority: Blocker
> Fix For: 4.1.1.Beta1
>
>
> usecase is that you can have a link to a connector, such as JBDS-IS could be installed by drag'n'drop to jboss tools or jbds.
> Similar to eclipse marketplace for marketplace urls something like:
> * https://devstudio.jboss.com/central/install?connector=com.jbds.integratio... or
> * http://download.jboss.org/jbosstools/central/install?CID=com.jbds.integra...
> would install the two connectors named "com.jbds.integration-stack.bpel" and "org.eclipse.m2e"
> This would allow drag'n'drop install from html docs.
> Consider also supporting this from any clipboard object (eg., dragged from an Acrobat Reader PDF or Microsoft Office doc). Would need to ensure we do lots of platform testing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
10 years, 7 months