June 2017 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-2757) ThreadAssociations#add uses getKey but then it overwrites the transactions associated with the thread

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-2757?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka reassigned JBTM-2757: ------------------------------------- Assignee: (was: Ondra Chaloupka) > ThreadAssociations#add uses getKey but then it overwrites the transactions associated with the thread > ----------------------------------------------------------------------------------------------------- > > Key: JBTM-2757 > URL: https://issues.jboss.org/browse/JBTM-2757 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: JTS > Affects Versions: 5.3.4.Final > Reporter: Ondra Chaloupka > > This issue came from Tom's investigation on JBTM-2756 (which came from static code analysis). > This issue points to the fact that for ThreadAssoction#add [1] tx is used as a getKey but then it overwrites the transactions associated with the thread. This seems to be a bug and need more investigation. > [1] https://github.com/jbosstm/narayana/blob/master/ArjunaJTS/jts/classes/com... -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2756) Static code analysis: nondeterministic locking behavior at ThreadAssociations#removeAll

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-2756?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka reassigned JBTM-2756: ------------------------------------- Assignee: (was: Ondra Chaloupka) > Static code analysis: nondeterministic locking behavior at ThreadAssociations#removeAll > --------------------------------------------------------------------------------------- > > Key: JBTM-2756 > URL: https://issues.jboss.org/browse/JBTM-2756 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: JTS > Affects Versions: 5.3.4.Final > Reporter: Ondra Chaloupka > > Static code analysis category: Nondeterministic locking behavior > _CID-17602_: Bad choice of lock object - Nondeterministic locking behavior > in class `ThreadAssociations` [1] at method `removeAll`. There is used synchronized block > where lock is acquired at `globalTxAssociations` and `txAssociations`. > The problem (one for txAssociations is described as) > lock_acquire: Acquiring lock `com.arjuna.ats.jts.extensions.`ThreadAssociations.txAssociations`. > lock_on_assigned_field: Locking on the object referenced by field `ThreadAssociations.txAssociations`. This lock acquisition may race with another thread assigning to this field. The contents of `ThreadAssociations.txAssociations` may change while a thread is inside the critical section, allowing two threads to enter the critical section simultaneously. > * Instead of using `ThreadAssociations.txAssociations` as a lock, create a final field of type Object which is only used as a lock. > assign_to_field: The expression `ThreadAssociations.txAssociations = null` assigns a new value to `ThreadAssociations.txAssociations`, a field whose contents are used as a lock. The locking behavior of this function may allow this assignment to occur multiple times. > Tom's reaction on this > {quote} > I think that the bug is that there is any synchronization at all on txAssociations because it looks to be indexed by Thread.currentThread(). > {quote} > [1] https://github.com/jbosstm/narayana/blob/master/ArjunaJTS/jts/classes/com... -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2857) Investigate XTS outbound bridge potential nullpointer issue

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-2857?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka reassigned JBTM-2857: ------------------------------------- Assignee: (was: Ondra Chaloupka) > Investigate XTS outbound bridge potential nullpointer issue > ----------------------------------------------------------- > > Key: JBTM-2857 > URL: https://issues.jboss.org/browse/JBTM-2857 > Project: JBoss Transaction Manager > Issue Type: Task > Components: XTS > Affects Versions: 5.5.2.Final > Reporter: Ondra Chaloupka > Priority: Minor > > During working on JBTM-2853 it was found `NullPointer` could be potentially thrown from `OutboundBridgeManager` when `getTransaction()` returns `null`. It's at time when thread is not associated with any txn. > Discussion about this at PR: https://github.com/jbosstm/narayana/pull/1133 > ``` > Transaction transaction = (Transaction)TransactionManager.transactionManager().getTransaction(); > ``` > https://github.com/jbosstm/narayana/blob/master/txbridge/src/main/java/or... > Goal is to investigate this potential exception being trouble or not and if such thing could happen or not. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2906) It's not possible to combine start and end flags in call of XATerminator.recover

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-2906?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka reassigned JBTM-2906: ------------------------------------- Assignee: (was: Ondra Chaloupka) > It's not possible to combine start and end flags in call of XATerminator.recover > --------------------------------------------------------------------------------- > > Key: JBTM-2906 > URL: https://issues.jboss.org/browse/JBTM-2906 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: JCA > Affects Versions: 5.6.1.Final > Reporter: Ondra Chaloupka > Priority: Minor > > Current implementation of {{XATerminator.recover}} (either for JTA or JTS) does not permit combining flags to use. > https://github.com/jbosstm/narayana/blob/5.6.1.Final/ArjunaJTA/jta/classe... > https://github.com/jbosstm/narayana/blob/5.6.1.Final/ArjunaJTS/jtax/class... > Flags are expected to be combined as their values are designed to use bitwise operators. Especially {{|}} is handy for starting and ending the recover scan in once. > Currently we need to call > {code} > XATerminator.recover(XAResource.TMSTARTRSCAN); > XATerminator.recover(XAResource.TMENDRSCAN); > {code} > Values are > {code} > XAResource.TMSTARTRSCAN : 16777216 : 1000000000000000000000000 > XAResource.TMENDRSCAN : 8388608 : 100000000000000000000000 > {code} > The way would be ability to call the {{recover}} like this > {code} > XATerminator.recover(XAResource.TMSTARTRSCAN | XAResource.TMENDRSCAN); > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2906) It's not possible to combine start and end flags in call of XATerminator.recover

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-2906?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka commented on JBTM-2906: --------------------------------------- I'm setting this as unassigned. I would get back to it possibly but it's not a high priority. Leaving for anybody interested in taking over. > It's not possible to combine start and end flags in call of XATerminator.recover > --------------------------------------------------------------------------------- > > Key: JBTM-2906 > URL: https://issues.jboss.org/browse/JBTM-2906 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: JCA > Affects Versions: 5.6.1.Final > Reporter: Ondra Chaloupka > Assignee: Ondra Chaloupka > Priority: Minor > > Current implementation of {{XATerminator.recover}} (either for JTA or JTS) does not permit combining flags to use. > https://github.com/jbosstm/narayana/blob/5.6.1.Final/ArjunaJTA/jta/classe... > https://github.com/jbosstm/narayana/blob/5.6.1.Final/ArjunaJTS/jtax/class... > Flags are expected to be combined as their values are designed to use bitwise operators. Especially {{|}} is handy for starting and ending the recover scan in once. > Currently we need to call > {code} > XATerminator.recover(XAResource.TMSTARTRSCAN); > XATerminator.recover(XAResource.TMENDRSCAN); > {code} > Values are > {code} > XAResource.TMSTARTRSCAN : 16777216 : 1000000000000000000000000 > XAResource.TMENDRSCAN : 8388608 : 100000000000000000000000 > {code} > The way would be ability to call the {{recover}} like this > {code} > XATerminator.recover(XAResource.TMSTARTRSCAN | XAResource.TMENDRSCAN); > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2882) Automatize XTS ssl quickstart to be tested in CI

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-2882?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka updated JBTM-2882: ---------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done > Automatize XTS ssl quickstart to be tested in CI > ------------------------------------------------ > > Key: JBTM-2882 > URL: https://issues.jboss.org/browse/JBTM-2882 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: XTS > Affects Versions: 5.5.6.Final > Reporter: Ondra Chaloupka > Assignee: Ondra Chaloupka > > The ssl XTS quickstart is not automatize to be run in CI testing. Paul created nice document with steps > https://github.com/jbosstm/quickstart/tree/master/XTS/ssl > but it can't be used in CI. > The goal of this enhancement is automatize steps described in the quickstart (plus adjust quickstart REAME.md if not appropriate) and get the quickstart being run in CI. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2886) Automatize XTS ssl quickstart to be tested in CI on Windows

by Ondra Chaloupka (JIRA)

[ https://issues.jboss.org/browse/JBTM-2886?page=com.atlassian.jira.plugin.... ] Ondra Chaloupka reassigned JBTM-2886: ------------------------------------- Assignee: (was: Ondra Chaloupka) > Automatize XTS ssl quickstart to be tested in CI on Windows > ----------------------------------------------------------- > > Key: JBTM-2886 > URL: https://issues.jboss.org/browse/JBTM-2886 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: XTS > Affects Versions: 4.2 > Reporter: Ondra Chaloupka > > There was created a shell script for JBTM-2882 which automatize testing of XTS over SSL. The steps were already written in `README.md` but that was not run automatically on CI. > The linux version with shell script was provided but we need windows version with `.bat`. This is a followup task to provide the bat script for the automatization on Windows. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2820) Quickstart build karaf failed due to can not find the org.apache.felix:gogo-parent 1.0.1-SNAPSHOT

by Amos Feng (JIRA)

[ https://issues.jboss.org/browse/JBTM-2820?page=com.atlassian.jira.plugin.... ] Amos Feng closed JBTM-2820. --------------------------- Fix Version/s: 5.5.0.Final Resolution: Done > Quickstart build karaf failed due to can not find the org.apache.felix:gogo-parent 1.0.1-SNAPSHOT > ------------------------------------------------------------------------------------------------- > > Key: JBTM-2820 > URL: https://issues.jboss.org/browse/JBTM-2820 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.5.0.Final > > > http://narayanaci1.eng.hst.ams2.redhat.com/job/narayana-quickstarts/26 > {code} > [ERROR] Failed to execute goal on project org.apache.karaf.shell.core: Could not resolve dependencies for project org.apache.karaf.shell:org.apache.karaf.shell.core:bundle:4.1.0-SNAPSHOT: Failed to collect dependencies at org.apache.felix:org.apache.felix.gogo.runtime:jar:1.0.1-SNAPSHOT: Failed to read artifact descriptor for org.apache.felix:org.apache.felix.gogo.runtime:jar:1.0.1-SNAPSHOT: Could not find artifact org.apache.felix:gogo-parent:pom:1.0.1-SNAPSHOT in apache-snapshots (http://repository.apache.org/content/groups/snapshots-group) -> [Help 1] > {code} > We have to disable the karaf quickstart until the upstream has fixed this issue or the 4.1.0 release -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2895) Upgrade the spring-boot framework version of the quickstart

by Amos Feng (JIRA)

[ https://issues.jboss.org/browse/JBTM-2895?page=com.atlassian.jira.plugin.... ] Amos Feng closed JBTM-2895. --------------------------- Fix Version/s: 5.6.0.Final Resolution: Done > Upgrade the spring-boot framework version of the quickstart > ----------------------------------------------------------- > > Key: JBTM-2895 > URL: https://issues.jboss.org/browse/JBTM-2895 > Project: JBoss Transaction Manager > Issue Type: Task > Components: Demonstrator > Reporter: Amos Feng > Assignee: Amos Feng > Fix For: 5.6.0.Final > > > The current GA release of spring boot is 1.5.3.RELEASE -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-2900) Byteman fails to start on IBM JDK (quickstart)

by Tom Jenkinson (JIRA)

[ https://issues.jboss.org/browse/JBTM-2900?page=com.atlassian.jira.plugin.... ] Tom Jenkinson updated JBTM-2900: -------------------------------- Fix Version/s: 5.6.0.Final > Byteman fails to start on IBM JDK (quickstart) > ---------------------------------------------- > > Key: JBTM-2900 > URL: https://issues.jboss.org/browse/JBTM-2900 > Project: JBoss Transaction Manager > Issue Type: Bug > Affects Versions: 4.2 > Reporter: Ivan Straka > Assignee: Ivan Straka > Priority: Minor > Fix For: 5.6.0.Final > > > Byteman fails to start on IBM JDK for jta-and-hibernate-standalone quickstart. > output: > {code:java} > Running org.jboss.narayana.quickstart.jta.TestCase > byteman jar is /home/hudson/.m2/repository/org/jboss/byteman/byteman/3.0.3/byteman-3.0.3.jar > *** java.lang.instrument ASSERTION FAILED ***: "jvmtierror == JVMTI_ERROR_NOT_AVAILABLE" at JPLISAgent.c line: 1009 > Setting org.jboss.byteman.allow.config.update=true > java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:95) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:55) > at java.lang.reflect.Method.invoke(Method.java:508) > at sun.instrument.InstrumentationImpl.loadClassAndStartAgent(InstrumentationImpl.java:408) > at sun.instrument.InstrumentationImpl.loadClassAndCallAgentmain(InstrumentationImpl.java:433) > at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibraryImpl(Native Method) > at com.ibm.tools.attach.javaSE.Attachment.loadAgentLibrary(Attachment.java:309) > at com.ibm.tools.attach.javaSE.Attachment.parseLoadAgent(Attachment.java:287) > at com.ibm.tools.attach.javaSE.Attachment.doCommand(Attachment.java:168) > at com.ibm.tools.attach.javaSE.Attachment.run(Attachment.java:128) > Caused by: java.lang.UnsupportedOperationException: adding retransformable transformers is not supported in this environment > at sun.instrument.InstrumentationImpl.addTransformer(InstrumentationImpl.java:100) > Exception in thread "Attachment 45368" Agent failed to start! > at org.jboss.byteman.agent.Main.premain(Main.java:275) > at org.jboss.byteman.agent.Main.agentmain(Main.java:305) > ... 11 more > JVMJ9TI064E Agent initialization function Agent_OnAttach failed for library instrument, return code 102 > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

6 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues June 2017