July 2020 - jbossts-issues - Jboss List Archives

[JBoss JIRA] (JBTM-3294) Include a custom HTTP LRA version header on REST calls made by our implementation

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3294?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3294: ----------------------------------- Fix Version/s: 5.next > Include a custom HTTP LRA version header on REST calls made by our implementation > --------------------------------------------------------------------------------- > > Key: JBTM-3294 > URL: https://issues.redhat.com/browse/JBTM-3294 > Project: JBoss Transaction Manager > Issue Type: Enhancement > Components: LRA > Affects Versions: 5.10.4.Final > Reporter: Michael Musgrove > Assignee: Ondrej Chaloupka > Priority: Blocker > Fix For: 5.next > > > Our implementation of the LRA specification exposes REST endpoints whose semantics may change over time. As the LRA spec evolves users will need a guarantee that the endpoints behave consistently. > To avoid introducing breaking changes I propose that we version REST API calls made by the implementation using a version header, something like: > bq. OpenStack-API-Version: narayana LRA 5.10.5.Final > or > bq. OpenStack-API-Version: narayana LRA 5.10.5.Final https://<the location of our OpenAPI document> > I went for the [OpenStack guideline|https://specs.openstack.org/openstack/api-wg/guidelines/headers...] since it was the only standard I could find for custom headers. > A reason it is narayana specific is that our API offers more than the spec requires. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3307) LRACoordinatorRecovery2TestCase regularly fails on CI

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3307?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3307: ----------------------------------- Fix Version/s: 5.next > LRACoordinatorRecovery2TestCase regularly fails on CI > ----------------------------------------------------- > > Key: JBTM-3307 > URL: https://issues.redhat.com/browse/JBTM-3307 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.4.Final > Reporter: Michael Musgrove > Assignee: Ondrej Chaloupka > Priority: Blocker > Fix For: 5.next > > > The test regularly fails CI > [ERROR] testRecovery2(io.narayana.lra.coordinator.LRACoordinatorRecovery2TestCase) Time elapsed: 30.455 s <<< FAILURE! > java.lang.AssertionError: LRA with short timeout should not be active > presumably due to a timing issue (since I cannot reproduce it on my laptop). I will see if there is a way to make the test more robust. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3065) Check that starting LRA's via CDI and API in the same method works

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3065?page=com.atlassian.jira.plugin... ] Michael Musgrove reassigned JBTM-3065: -------------------------------------- Assignee: (was: Michael Musgrove) > Check that starting LRA's via CDI and API in the same method works > ------------------------------------------------------------------ > > Key: JBTM-3065 > URL: https://issues.redhat.com/browse/JBTM-3065 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.9.0.Final > Reporter: Michael Musgrove > Priority: Optional > Fix For: 6.later > > > The LRA spec supports starting LRA's via a Java API or via Java annotations. If the two approaches are used together in the same resource method then the LRA started via the API should be nested inside the one started by an annotation. > If the annotated class also contains @Compensate and @Complete annotations (which means that the resource should join the outer LRA) and the resource method Joins the nested LRA then the resource should receive callbacks for both the outer and nested LRA's. > The following code shows an example: > {code} > @PUT > @LRA(LRA.Type.REQUIRES_NEW) // starts a new LRA on entry > public String doInTransaction() { > URL lraId = lraClient.startLRA(...); // starts a nested LRA > lraClient.join(...) // join the nested LRA > lraClient.closeLRA(lraId); // close the nested LRA > // assert that the nested callbacks were invoked > // assert that the callbacks for the outer LRA have not been called yet > } > {code} > Similar comments apply if the resource joins via the LRAManagement API: > {code} > @Inject > private LRAManagement lraManagement; > public String doInTransaction() { > lraManagement.joinLRA(this, lraId, 0L, TimeUnit.SECONDS); > // etc > {code} -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3065) Check that starting LRA's via CDI and API in the same method works

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3065?page=com.atlassian.jira.plugin... ] Michael Musgrove commented on JBTM-3065: ---------------------------------------- I marked the priority as optional for now since we are not supporting a java client API in the initial release of MP LRA. If a later release of MP LRA plans on providing a java API then the priority of this issue should be raised. > Check that starting LRA's via CDI and API in the same method works > ------------------------------------------------------------------ > > Key: JBTM-3065 > URL: https://issues.redhat.com/browse/JBTM-3065 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.9.0.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Optional > Fix For: 6.later > > > The LRA spec supports starting LRA's via a Java API or via Java annotations. If the two approaches are used together in the same resource method then the LRA started via the API should be nested inside the one started by an annotation. > If the annotated class also contains @Compensate and @Complete annotations (which means that the resource should join the outer LRA) and the resource method Joins the nested LRA then the resource should receive callbacks for both the outer and nested LRA's. > The following code shows an example: > {code} > @PUT > @LRA(LRA.Type.REQUIRES_NEW) // starts a new LRA on entry > public String doInTransaction() { > URL lraId = lraClient.startLRA(...); // starts a nested LRA > lraClient.join(...) // join the nested LRA > lraClient.closeLRA(lraId); // close the nested LRA > // assert that the nested callbacks were invoked > // assert that the callbacks for the outer LRA have not been called yet > } > {code} > Similar comments apply if the resource joins via the LRAManagement API: > {code} > @Inject > private LRAManagement lraManagement; > public String doInTransaction() { > lraManagement.joinLRA(this, lraId, 0L, TimeUnit.SECONDS); > // etc > {code} -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3065) Check that starting LRA's via CDI and API in the same method works

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3065?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3065: ----------------------------------- Priority: Optional (was: Major) > Check that starting LRA's via CDI and API in the same method works > ------------------------------------------------------------------ > > Key: JBTM-3065 > URL: https://issues.redhat.com/browse/JBTM-3065 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.9.0.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Optional > Fix For: 6.later > > > The LRA spec supports starting LRA's via a Java API or via Java annotations. If the two approaches are used together in the same resource method then the LRA started via the API should be nested inside the one started by an annotation. > If the annotated class also contains @Compensate and @Complete annotations (which means that the resource should join the outer LRA) and the resource method Joins the nested LRA then the resource should receive callbacks for both the outer and nested LRA's. > The following code shows an example: > {code} > @PUT > @LRA(LRA.Type.REQUIRES_NEW) // starts a new LRA on entry > public String doInTransaction() { > URL lraId = lraClient.startLRA(...); // starts a nested LRA > lraClient.join(...) // join the nested LRA > lraClient.closeLRA(lraId); // close the nested LRA > // assert that the nested callbacks were invoked > // assert that the callbacks for the outer LRA have not been called yet > } > {code} > Similar comments apply if the resource joins via the LRAManagement API: > {code} > @Inject > private LRAManagement lraManagement; > public String doInTransaction() { > lraManagement.joinLRA(this, lraId, 0L, TimeUnit.SECONDS); > // etc > {code} -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3342) LRA annotated method should expose the parent context header

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3342?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3342: ----------------------------------- Description: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the LRA_HTTP_PARENT_CONTEXT_HEADER ([https://github.com/eclipse/microprofile-lra/blob/master/api/src/main/java...]). (was: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [parent context header|#L132]]. ) > LRA annotated method should expose the parent context header > ------------------------------------------------------------ > > Key: JBTM-3342 > URL: https://issues.redhat.com/browse/JBTM-3342 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Blocker > Fix For: 5.next > > > When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the LRA_HTTP_PARENT_CONTEXT_HEADER ([https://github.com/eclipse/microprofile-lra/blob/master/api/src/main/java...]). -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3342) LRA annotated method should expose the parent context header

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3342?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3342: ----------------------------------- Description: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [parent context header|#L132]]. was: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [header|[https://github.com/eclipse/microprofile-lra/blob/master/api/src/m... > LRA annotated method should expose the parent context header > ------------------------------------------------------------ > > Key: JBTM-3342 > URL: https://issues.redhat.com/browse/JBTM-3342 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Blocker > Fix For: 5.next > > > When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [parent context header|#L132]]. > -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3342) LRA annotated method should expose the parent context header

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3342?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3342: ----------------------------------- Description: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [header|[https://github.com/eclipse/microprofile-lra/blob/master/api/src/m... was: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_PARENT_CONTEXT_HEADER|[https://github.com/eclipse/microprofile-l... > LRA annotated method should expose the parent context header > ------------------------------------------------------------ > > Key: JBTM-3342 > URL: https://issues.redhat.com/browse/JBTM-3342 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Blocker > Fix For: 5.next > > > When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [header|[https://github.com/eclipse/microprofile-lra/blob/master/api/src/m... > -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3342) LRA annotated method should expose the parent context header

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3342?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3342: ----------------------------------- Description: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_PARENT_CONTEXT_HEADER|[https://github.com/eclipse/microprofile-l... was:When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [[LRA_HTTP_PARENT_CONTEXT_HEADER||http://example.com/] [https://github.com/eclipse/microprofile-lra/blob/master/api/src/main/java...] []|http://example.com/] http header. > LRA annotated method should expose the parent context header > ------------------------------------------------------------ > > Key: JBTM-3342 > URL: https://issues.redhat.com/browse/JBTM-3342 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Blocker > Fix For: 5.next > > > When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_PARENT_CONTEXT_HEADER|[https://github.com/eclipse/microprofile-l... > -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

[JBoss JIRA] (JBTM-3342) LRA annotated method should expose the parent context header

by Michael Musgrove (Jira)

[ https://issues.redhat.com/browse/JBTM-3342?page=com.atlassian.jira.plugin... ] Michael Musgrove updated JBTM-3342: ----------------------------------- Description: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [[LRA_HTTP_PARENT_CONTEXT_HEADER||http://example.com/] [https://github.com/eclipse/microprofile-lra/blob/master/api/src/main/java...] []|http://example.com/] http header. (was: When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [LRA_HTTP_ENDED_CONTEXT_HEADER|http://example.com/] http header.) > LRA annotated method should expose the parent context header > ------------------------------------------------------------ > > Key: JBTM-3342 > URL: https://issues.redhat.com/browse/JBTM-3342 > Project: JBoss Transaction Manager > Issue Type: Bug > Components: LRA > Affects Versions: 5.10.5.Final > Reporter: Michael Musgrove > Assignee: Michael Musgrove > Priority: Blocker > Fix For: 5.next > > > When a method annotated with @LRA is invoked with a nested context the parent context should be made available to the invoked method via the [[LRA_HTTP_PARENT_CONTEXT_HEADER||http://example.com/] [https://github.com/eclipse/microprofile-lra/blob/master/api/src/main/java...] []|http://example.com/] http header. -- This message was sent by Atlassian Jira (v7.13.8#713008)

3 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

jbossts-issues July 2020