[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
3:43 p.m.
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence under
profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:45 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Pete Muir reassigned JBSEAM-2093:
---------------------------------
Assignee: Pete Muir
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
Assigned To: Pete Muir
Fix For: 2.0.x
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:45 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Pete Muir updated JBSEAM-2093:
------------------------------
Fix Version/s: 2.0.x
Priority: Minor (was: Major)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
Assigned To: Pete Muir
Priority: Minor
Fix For: 2.0.x
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:47 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=comments#action_12382250 ]
Pete Muir commented on JBSEAM-2093:
-----------------------------------
Are you using Hibernate, if so HibernatePersistenceProvider will be being used (and hence
the Id looked up via the session).
I would like to see a profile of the use of PersistenceProvider.getId including stack so
we can see if there are excessive calls from one point, and if we can cleverly cache the
identifier there.
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
Assigned To: Pete Muir
Priority: Minor
Fix For: 2.0.x
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Mikhail Grushinskiy updated JBSEAM-2093:
----------------------------------------
Attachment: AnnotationsTest.java
Attaching little program to compare performance of cached isAnnotationPresent with
direct repetivtive calls to JDK isAnnotationPresent
Run1 time=1031ms
Run2 time=47ms
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
Assigned To: Pete Muir
Priority: Minor
Fix For: 2.0.x
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:15 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=comments#action_12382285 ]
Christian Bauer commented on JBSEAM-2093:
-----------------------------------------
This is not a profiler trace. Please attach a profiler trace.
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
Assigned To: Pete Muir
Priority: Minor
Fix For: 2.0.x
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Pete Muir updated JBSEAM-2093:
------------------------------
Assignee: (was: Pete Muir)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.0.x
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:10 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Pete Muir updated JBSEAM-2093:
------------------------------
Fix Version/s: 2.1.0.GA
(was: 2.0.x)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.1.0.GA
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:12 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Pete Muir updated JBSEAM-2093:
------------------------------
Component/s: Performance and Scalability
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.1.0.GA
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:59 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Norman Richards updated JBSEAM-2093:
------------------------------------
Fix Version/s: 2.1.0.GA
(was: 2.1.0.A1)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.1.0.GA
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:29 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Pete Muir updated JBSEAM-2093:
------------------------------
Fix Version/s: 2.1.0.GA
(was: 2.1.0.BETA1)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: JBoss Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.1.0.GA
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:20 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[ http://jira.jboss.com/jira/browse/JBSEAM-2093?page=all ]
Pete Muir updated JBSEAM-2093:
------------------------------
Fix Version/s: 2.1.0.BETA1
(was: 2.1.0.GA)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: http://jira.jboss.com/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.1.0.BETA1
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:16 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[
https://jira.jboss.org/jira/browse/JBSEAM-2093?page=com.atlassian.jira.pl...
]
Pete Muir updated JBSEAM-2093:
------------------------------
Fix Version/s: 2.1.0.BETA2
(was: 2.1.0.BETA1)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: https://jira.jboss.org/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.1.0.BETA2
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:11 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[
https://jira.jboss.org/jira/browse/JBSEAM-2093?page=com.atlassian.jira.pl...
]
Pete Muir updated JBSEAM-2093:
------------------------------
Fix Version/s: 2.1.1.CR1
(was: 2.1.0.CR1)
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: https://jira.jboss.org/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Priority: Minor
Fix For: 2.1.1.CR1
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:45 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[
https://jira.jboss.org/jira/browse/JBSEAM-2093?page=com.atlassian.jira.pl...
]
Shane Bryzak reassigned JBSEAM-2093:
------------------------------------
Assignee: Shane Bryzak
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: https://jira.jboss.org/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Assignee: Shane Bryzak
Priority: Minor
Fix For: 2.1.1.CR1
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:25 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[
https://jira.jboss.org/jira/browse/JBSEAM-2093?page=com.atlassian.jira.pl...
]
Shane Bryzak closed JBSEAM-2093.
--------------------------------
Resolution: Won't Fix
Closing this issue for lack of a profilable test case. Please re-open if a test case can
be provided.
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: https://jira.jboss.org/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Assignee: Shane Bryzak
Priority: Minor
Fix For: 2.1.1.CR1
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:21 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[
https://jira.jboss.org/jira/browse/JBSEAM-2093?page=com.atlassian.jira.pl...
]
Ken Wang commented on JBSEAM-2093:
----------------------------------
Shane, I feel very disappointed about this issue and you.
You are assigned to solve this issue, but you DID require the issue reporter to give the
every detail about how to solve it, and you were waiting to pick the lowest peach.
Is there any easier way to show and solve the issue?
Is there any easier work?
How about run the attached program on you own computer????
You gave "won't fix" response, why set the fixed version as "2.1.1
CR1"???
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: https://jira.jboss.org/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Assignee: Shane Bryzak
Priority: Minor
Fix For: 2.1.1.CR1
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[
https://jira.jboss.org/jira/browse/JBSEAM-2093?page=com.atlassian.jira.pl...
]
Stuart Douglas commented on JBSEAM-2093:
----------------------------------------
I can't imagine that shaving millions of a second off calls that are only made a
couple of times per page view ranks very high on the priority list. This is not an issue
that would have any measurable effect on performance.
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: https://jira.jboss.org/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Assignee: Shane Bryzak
Priority: Minor
Fix For: 2.1.1.CR1
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:30 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2093) Optimize getting Id in Seam code for better performance
[
https://jira.jboss.org/jira/browse/JBSEAM-2093?page=com.atlassian.jira.pl...
]
Shane Bryzak commented on JBSEAM-2093:
--------------------------------------
@Ken: As Christian already pointed out (almost 2 years ago now) the attached program is
not a profilable test case, and in the time since we have not received one. Running an
iteration 5 million times to show a difference of less than 1 second by no means reflects
any real world scenario, and as Stuart correctly points out would not have any measurable
effect on performance. If you can demonstrate otherwise, then please provide us with a
test case and we will be more than happy to reopen the issue.
Optimize getting Id in Seam code for better performance
-------------------------------------------------------
Key: JBSEAM-2093
URL: https://jira.jboss.org/jira/browse/JBSEAM-2093
Project: Seam
Issue Type: Feature Request
Components: Performance and Scalability
Reporter: Mikhail Grushinskiy
Assignee: Shane Bryzak
Priority: Minor
Fix For: 2.1.1.CR1
Attachments: AnnotationsTest.java
This sequence of calls (used in PersistenceProvider) is quite slow
Entity.forClass(bean.getClass()).getIdentifier(bean);
1) Entity.forClass() is reading annotations using JDK 5 methods (JDK 5 annotation reading
is not that fast). Can it be cached?
2) JDK 5 reflection is used to get bean id (which is slower than optmized reflection with
cglib)
3) There could be other reasons as well. I think repetitive calling of this sequence
under profiler will give better picture.
from PersistenceProvider.java
/**
* Get the value of the entity identifier attribute.
*
* @param bean a managed entity instance
*/
public Object getId(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getIdentifier(bean);
}
/**
* Get the name of the entity
*
* @param bean
* @param entityManager
*/
public String getName(Object bean, EntityManager entityManager)
{
return Entity.forClass(bean.getClass()).getName();
}
/**
* Get the value of the entity version attribute.
*
* @param bean a managed entity instance
*/
public Object getVersion(Object bean, EntityManager entityManager)
{
return Entity.forClass( bean.getClass() ).getVersion(bean);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5416
days inactive
6078
days old
18 comments
7 participants
participants (7)
-
Christian Bauer (JIRA) -
Ken Wang (JIRA)
-
Mikhail Grushinskiy (JIRA)
-
Norman Richards (JIRA)
-
Pete Muir (JIRA)
-
Shane Bryzak (JIRA)
-
Stuart Douglas (JIRA)