[aerogear-dev] AEROGEAR-826 Android: timeout for pipe
Summers Pittman
supittma at redhat.com
Wed Apr 3 16:33:01 EDT 2013
I've submitted 2 PRs. One is for the implementation and the other is for the integration tests.
Couple of quick things I want to bring up for comment:
1) I'm using controller-aerogear.rhcloud.com/aerogear-controller-demo as the base url for my tests and a timeout of 1ms. I doubt OpenShift will respond faster than that but it might be nice if we had a tarpit service where the http connection is made but no data is sent to make testing less reliant on swingy behavior. WDYT?
2) I'm defaulting the timeout to MAX_INT. HttpURLConnection (which does the heavy lifting) disables timeouts if a value of 0 is passed. Should timeout be defaulted to 0 instead? On the one hand I like having timeouts disabled by default, but on the other hand I feel like 0 is a very ambiguous value. MAX_INT very clearly means "don't time out for a very long time". WDYT?
Summers
More information about the aerogear-dev
mailing list