[aerogear-dev] AEROGEAR-826 Android: timeout for pipe

[Christos Vasilakis]

Hi

On Apr 3, 2013, at 11:33 PM, Summers Pittman <supittma at redhat.com> wrote:

> I've submitted 2 PRs.  One is for the implementation and the other is for the integration tests.
> 
> Couple of quick things I want to bring up for comment:
> 
> 1) I'm using controller-aerogear.rhcloud.com/aerogear-controller-demo as the base url for my tests and a timeout of 1ms.  I doubt OpenShift will respond faster than that but it might be nice if we had a tarpit service where the http connection is made but no data is sent to make testing less reliant on swingy behavior.  WDYT?

faced similar issue in the iOS [1], had to create a separate project [2] that blocks the request for some amount of time so I can verify cancel and timeout works correctly. +1 to have this service 


> 
> 2) I'm defaulting the timeout to MAX_INT.  HttpURLConnection (which does the heavy lifting) disables timeouts if a value of 0 is passed.  Should timeout be defaulted to 0 instead?  On the one hand I like having timeouts disabled by default, but on the other hand I feel like 0 is a very ambiguous value.  MAX_INT very clearly means "don't time out for a very long time".  WDYT?

+1

Thanks,
Christos



[1] http://lists.jboss.org/pipermail/aerogear-dev/2013-February/001704.html
[2] https://github.com/cvasilak/RESTfulExample


> 
> Summers
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev