[aerogear-dev] Providing Tests with PR's

Sebastien Blanc scm.blanc at gmail.com
Thu Jan 31 12:15:47 EST 2013


Test Driven Development is for sure the way to go !
+1


On Thu, Jan 31, 2013 at 6:12 PM, Kris Borchers <kris at redhat.com> wrote:

> I want to throw this out to the list for feedback. Something we have been
> doing for a while now with the jQuery project is to require a unit test(s)
> for any PR or change committed. This has worked very well in two ways.
> First, it provides a built in way to see the issue being fixed/implemented
> within the PR. That way, the reviewer doesn't have to build their own
> test(s) to see if the issue being addressed is actually fixed. Second, it
> helps prevent regressions down the road since more of the code is covered
> by tests so you know if some change you think is unrelated breaks something
> that fixed days, weeks, years ago.
>
> I would like to suggest we make this policy for at least the JS library
> (since that is the one I review most often) but I believe this policy would
> be useful across the entire project. Let me know what you think.
>
> Thanks,
> Kris
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20130131/c0bca37a/attachment.html 


More information about the aerogear-dev mailing list