[aerogear-dev] Bundling Dependencies

[Kris Borchers]

So I have a dilemma on which I would like input from the team. In https://issues.jboss.org/browse/AGJS-48 qmx reports that he gets:

Uncaught ReferenceError: vertx is not defined at aerogear.js:2627

when using AeroGear.js in a blank page. The reason for this is that the full build of AeroGear.js contains the new vert.x and STOMP over websocket adapters for Notifier. These adapters have dependencies on vertxbus.js and stomp.js respectively. Since they are not included in the page, you get that error. Here is the dilemma.

Do I bundle those files into AeroGear.js as part of the build when those adapters are included or not? The reason I did not is because they are external dependencies and I didn't want them bloating the file size just like we do with jQuery. That said, it's obviously easy to not realize you need those files, especially if you grab AeroGear.js and don't intend on using the Notifier bits or just grab it and throw it in a page and see those errors as qmx did.

Thoughts?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20130708/9bf20f76/attachment.html