[aerogear-dev] [UnifiedPush] Refactorings

Karel Piwko kpiwko at redhat.com
Mon Jan 20 06:02:17 EST 2014


Matthias, 

this looks like a great idea.

It would be great if refactoring could be done in such way that our integration
tests can on api-only artifacts, that are stable. That would help us to write
tests in cleaner way (now we require ups to be cloned to specific location
and use maven-resources-plugin), also it would avoid situation where we test
internals which are often subject to change. 

Current list https://gist.github.com/kpiwko/8518205. We should work in order to
let tests use as less "impl" stuff as possible.

Something like:
* message-api (cache, sender)
* model-api (now, it is confusing to have Variant in .api package and
  AbstractVariant in .model package, for instance)
* core-api ?(dunno)
* service-api (service, sender)

Some of the APIs that are supposed to be implemented by others
(for instance SenderService is provided by SP)could also make a nice SPI
module.

Karel

On Fri, 17 Jan 2014 17:31:09 +0100
Matthias Wessendorf <matzew at apache.org> wrote:

> Hi,
> 
> over the next weeks, after we get the 0.10.0 out, there will be some
> refactorings on different parts of the server:
> 
>    - make the 'core' the sending logic a little more isolated
>    - look into a better 'abstraction' for the data storage
> 
> I think this might lead to new (sub)projects and JAR files. I was
> wondering, do folks like a
> 
>    - pom.xml
>    - sender-component/
>    - data/
>       - api
>       - some impl projects
>    - pushee/ (the server as is today, but including above 'components')
>    - database-scripts (the CLI files for WildFly/AS)
> 
> Greetings, Matthias
> 



More information about the aerogear-dev mailing list