[aerogear-dev] UnifiedPush: Identify sender client

[Matthias Wessendorf]

On Mon, Jun 2, 2014 at 1:30 PM, Sebastien Blanc <scm.blanc at gmail.com> wrote:

> Sounds good.
>

I've sent a PR, using the 'aerogear-sender' header:
https://github.com/aerogear/aerogear-unifiedpush-server/pull/182/files#diff-230cf59cf98db2327d2c29dad7234173R54

Let me know if someone has feelings for a different (better?) name of the
custom header;



> Do we want to document that as well ?
>


yes, eventually (e.g. on the REST API doc)



> Because you mention the example of a company building a Ruby Sender, maybe
> they would like to use that custom header as well for their stats.
>

yes, that's fine


>
>
>
> On Mon, Jun 2, 2014 at 11:44 AM, Matthias Wessendorf <matzew at apache.org>
> wrote:
>
>> Good afternoon!
>>
>> for [1] I'd like to propose we introduce a custom http-header
>> ('aerogear-sender') to be submitted by our "clients" that perform a send in
>> order to show the user on the 'stats' page what client was used to submit a
>> 'push job' to the server.
>>
>> I have identified the following clients to be updated (see sub-tasks of
>> [1]):
>> * Java-Sender
>> * Node-Sender
>> * AdminUI (compose a push UI part)
>>
>> On our clients we can simply apply the new custom header, however that
>> does not work for pure invocation of our REST APIs (e.g. via cURL or if
>> someone did build their own sender (E.g. some company builds an internal
>> Ruby sender)).  For that case I suggest to simply read the "user-agent"
>> header.
>>
>> Basic rule: If there is no "aerogear-sender" header present, we read the
>> value of the "user-agent" header.
>>
>> Any thoughts ?
>>
>> -Matthias
>>
>> [1] https://issues.jboss.org/browse/AGPUSH-653
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20140602/d3b19208/attachment.html