[aerogear-dev] UnifiedPush Server domain model

[Andrea Vibelli]

I would also vote for waiting after 0.11.0 release (+1 on this very nice
refactoring).

Andrea
 

Bruno Oliveira wrote
> I would vote to stabilize 0.11.0 before we start to make big changes.
> 
> On 2014-06-12, Karel Piwko wrote:
>> On Wed, 11 Jun 2014 16:48:07 +0200
>> Sebastien Blanc <

> scm.blanc@

> > wrote:
>>
>> > I'm also +1 but maybe better to wait after 0.11 no ?
>> >
>> Likely, too many things have been changed in 0.11 already ;-)
>> >
>> >
>> > On Wed, Jun 11, 2014 at 4:36 PM, Matthias Wessendorf <

> matzew@

> >
>> > wrote:
>> >
>> > > +1 on that!
>> > >
>> > > Should we do that for the 0.11 ? Or after?
>> > >
>> > >
>> > > On Wed, Jun 11, 2014 at 3:38 PM, Karel Piwko <

> kpiwko@

> > wrote:
>> > >
>> > >> +1 on not having separate table per variant type and using different
>> > >> inheritance model here - for instance a discriminator column.
>> > >>
>> > >> Karel
>> > >>
>> > >> On Wed, 11 Jun 2014 15:14:21 +0200
>> > >> Erik Jan de Wit <

> edewit@

> > wrote:
>> > >>
>> > >> > Hi,
>> > >> >
>> > >> > Right now the domain model of the UnifiedPush Server has the
>> variants
>> > >> split
>> > >> > into separate collections.
>> > >> >
>> > >> >
>> > >>
>> https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/PushApplication.java#L44-L50
>> > >> >
>> > >> > This could be improved to only use one collection, we’ll get more
>> > >> > extendibility (adding another variant type for instance) and
>> remove
>> > >> code like
>> > >> > this:
>> > >> >
>> > >> >
>> > >>
>> https://github.com/edewit/aerogear-unifiedpush-server/blob/master/model/jpa/src/main/java/org/jboss/aerogear/unifiedpush/jpa/dao/impl/JPAPushApplicationDao.java#L93-L96
>> > >> >
>> > >> > In places where you only want the iOS variants for instance you
>> could
>> > >> either
>> > >> > query them, or have a getter that collects them by type.
>> > >> >
>> > >> > What do you think?
>> > >> >
>> > >> >       Cheers,
>> > >> >               Erik Jan
>> > >> >
>> > >>
>> > >> _______________________________________________
>> > >> aerogear-dev mailing list
>> > >> 

> aerogear-dev at .jboss

>> > >> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> > >>
>> > >
>> > >
>> > >
>> > > --
>> > > Matthias Wessendorf
>> > >
>> > > blog: http://matthiaswessendorf.wordpress.com/
>> > > sessions: http://www.slideshare.net/mwessendorf
>> > > twitter: http://twitter.com/mwessendorf
>> > >
>> > > _______________________________________________
>> > > aerogear-dev mailing list
>> > > 

> aerogear-dev at .jboss

>> > > https://lists.jboss.org/mailman/listinfo/aerogear-dev
>> > >
>>
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> 

> aerogear-dev at .jboss

>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
> 
> --
> 
> abstractj
> _______________________________________________
> aerogear-dev mailing list

> aerogear-dev at .jboss

> https://lists.jboss.org/mailman/listinfo/aerogear-dev





--
View this message in context: http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-UnifiedPush-Server-domain-model-tp8138p8153.html
Sent from the aerogear-dev mailing list archive at Nabble.com.