[aerogear-dev] external config for senders ?

[Lucas Holmquist]

> On Oct 28, 2014, at 11:00 AM, Lucas Holmquist <lholmqui at redhat.com> wrote:
> 
>> 
>> On Oct 28, 2014, at 10:54 AM, Matthias Wessendorf <matzew at apache.org <mailto:matzew at apache.org>> wrote:
>> 
>> 
>> 
>> On Tue, Oct 28, 2014 at 3:48 PM, Lucas Holmquist <lholmqui at redhat.com <mailto:lholmqui at redhat.com>> wrote:
>> technically, a user can already load the settings from an external config,
>> 
>> so, it's just a matter of updating the demo and 'document' it ? 
> 
> yea,  pretty much

i made some slight modifications to the node sender,  https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/pull/11 <https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/pull/11>

basically,  the constructor was only taking in the url of the UPS.  I changed this so you now pass in an Object with the url, applicationId, and masterSecret (which can be loaded from an external config file).

this makes the “send”’s options now optional.

see the update example in the PR to see the change

> 
>>  
>> 
>>> On Oct 28, 2014, at 10:43 AM, Matthias Wessendorf <matzew at apache.org <mailto:matzew at apache.org>> wrote:
>>> 
>>> 
>>> 
>>> On Tue, Oct 28, 2014 at 3:36 PM, Lucas Holmquist <lholmqui at redhat.com <mailto:lholmqui at redhat.com>> wrote:
>>> 
>>>> On Oct 28, 2014, at 10:31 AM, Matthias Wessendorf <matzew at apache.org <mailto:matzew at apache.org>> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> on the Cordova 1.0.2 push plugin, we now have the handy option to configure the server settings in an external JSON file.
>>>> 
>>>> 
>>>> A few days we spoke about this for the senders as well. Now, after a few days, I am wondering, does it make sense to have an external configuration file for our node.js/java senders ? 
>>> 
>>> for the node sender, this would be a nice thing, loading it should be as easy as  “require(‘external_config.json')"
>>> 
>>> 
>>> oh, that sounds quick :) sounds reasonable to do for next release ;-)
>>>  
>>> 
>>>> 
>>>> -Matthias
>>>> 
>>>> -- 
>>>> Matthias Wessendorf 
>>>> 
>>>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/>
>>>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf>
>>>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________________
>>>> aerogear-dev mailing list
>>>> aerogear-dev at lists.jboss.org <mailto:aerogear-dev at lists.jboss.org>
>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev>
>>> 
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev at lists.jboss.org <mailto:aerogear-dev at lists.jboss.org>
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev>
>>> 
>>> 
>>> 
>>> -- 
>>> Matthias Wessendorf 
>>> 
>>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/>
>>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf>
>>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev at lists.jboss.org <mailto:aerogear-dev at lists.jboss.org>
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev>
>> 
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org <mailto:aerogear-dev at lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev>
>> 
>> 
>> 
>> -- 
>> Matthias Wessendorf 
>> 
>> blog: http://matthiaswessendorf.wordpress.com/ <http://matthiaswessendorf.wordpress.com/>
>> sessions: http://www.slideshare.net/mwessendorf <http://www.slideshare.net/mwessendorf>
>> twitter: http://twitter.com/mwessendorf <http://twitter.com/mwessendorf>_______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org <mailto:aerogear-dev at lists.jboss.org>
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org <mailto:aerogear-dev at lists.jboss.org>
> https://lists.jboss.org/mailman/listinfo/aerogear-dev <https://lists.jboss.org/mailman/listinfo/aerogear-dev>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20141029/8ec6a4a2/attachment-0001.html