[aerogear-dev] Should Cordova push plugin dependencies be shrinkwrapped?

[Lukáš Fryč]

+1 it should definitely point to the specific version


On Thu, Sep 4, 2014 at 5:05 PM, Gorkem Ercan <gorkem.ercan at gmail.com> wrote:

> Hi All,
> I have been working cordova push quickstarts and noticed that on Android
> installation through JBoss tools started to fail.
>
> After a  bit of investigation  I figured that the failure occurs because
> push plugin defines cordova plugin "com.google.playservices" as a
> dependency through a git URL[1] that points to the master of the plugin's
> repo. Unfortunately this repo received a change [2] which started to use a
> new feature that was not implemented for JBoss tools. In this particular
> case, I am already implementing the missing feature so it should be all
> good soon. However I have doubts that referencing a dependency through
> master is a good idea. I think it may not only make it really difficult for
> us to reproduce cases but also unexpected behaviour may just appear.
>
>
> [1] https://github.com/MobileChromeApps/google-play-services
> [2]
> https://github.com/MobileChromeApps/google-play-services/commit/41c19152c21981c9a2f6497cc2100c317f5c660d
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20140904/6b4c4777/attachment.html