[aerogear-dev] UPS unit tests

[Karel Piwko]

On Wed, 2015-01-21 at 17:32 +0100, Matthias Wessendorf wrote:
> 
> 
> On Wed, Jan 21, 2015 at 5:29 PM, Summers Pittman <supittma at redhat.com>
> wrote:
>         On 01/21/2015 10:50 AM, Matthias Wessendorf wrote:
>         
>         > I think the problem that I have with using Arquillian is the
>         > time of execution for these integration tests. It boots up a
>         > container and stuff and just makes the test execution take a
>         > very long time. We spoke about that in the past, and didn't
>         > do Aquillian due to that.
>         I'm learning to alike Arquillian.  Would it be terribly to put
>         the Arq tests in a profile so they only get run if you pass
>         -Pit or something?
> 
> 
> nope - that sounds good, folder could be
> src/itest/java/....

Definitely +1 to Erik's change. itest folder is by default executed if
you run verify phase by maven-failsafe-plugin. 


Alternatively long running tests can be put into
https://github.com/aerogear/aerogear-unifiedpush-server-integration-tests/ but I would not qualify 15s for a long running test (despite it is 100% increase ;-).

> 
> 
> 
> and only enabled on a -Pit or -Pitests
>  
>           Eventually the tests may get to take long enough its
>         important.
>         
>         The android-maven-plugin does that so you aren't always firing
>         up Android VM's.  
>         > 
>         > 
>         > Not sure how others feel about it, but I'd prefer we dont
>         > boot a container inside our tests
>         > 
>         > On Wed, Jan 21, 2015 at 4:40 PM, Erik Jan de Wit
>         > <edewit at redhat.com> wrote:
>         >         Hi, 
>         >         
>         >         
>         >         The database unit tests of the UPS contain a lot of
>         >         setup code as setting up the database is done within
>         >         the test method. I’m proposing to remove this
>         >         ‘noise’ from the test and put it in a separate file.
>         >         Another thing that is setting up the dao's, when we
>         >         use arquillian weld container we can use injection
>         >         in our tests to further reduce the boilerplate, have
>         >         a look at an example:
>         >         
>         >         
>         >         https://github.com/edewit/aerogear-unifiedpush-server/blob/4bb63adce319df25e8e77d505f2844cf80ff5644/model/jpa/src/test/java/org/jboss/aerogear/unifiedpush/jpa/PushApplicationDaoTest.java
>         >         
>         >         
>         >         If you like I could do this for all these tests.
>         >         
>         >         
>         >         Cheers,
>         >         Erik Jan 
>         >         
>         >         _______________________________________________
>         >         aerogear-dev mailing list
>         >         aerogear-dev at lists.jboss.org
>         >         https://lists.jboss.org/mailman/listinfo/aerogear-dev
>         > 
>         > 
>         > 
>         > 
>         > -- 
>         > Matthias Wessendorf 
>         > 
>         > blog: http://matthiaswessendorf.wordpress.com/
>         > sessions: http://www.slideshare.net/mwessendorf
>         > twitter: http://twitter.com/mwessendorf
>         > 
>         > 
>         > _______________________________________________
>         > aerogear-dev mailing list
>         > aerogear-dev at lists.jboss.org
>         > https://lists.jboss.org/mailman/listinfo/aerogear-dev
>         
>         
>         -- 
>         Summers Pittman
>         >>Phone:404 941 4698
>         >>Java is my crack.
>         
>         _______________________________________________
>         aerogear-dev mailing list
>         aerogear-dev at lists.jboss.org
>         https://lists.jboss.org/mailman/listinfo/aerogear-dev
> 
> 
> 
> 
> -- 
> Matthias Wessendorf 
> 
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev