[aerogear-dev] UPS Node Sender client categories issue?

Wed Jul 15 15:16:24 EDT 2015

So i've sent PR's for this now,
https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/pull/21  and
https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/pull/20

first link is for the 0.7.x release  and second is for master

On Tue, Jul 14, 2015 at 11:23 AM, Luke Holmquist <lholmqui at redhat.com>
wrote:

>
>
> On Tue, Jul 14, 2015 at 11:05 AM, Matthias Wessendorf <matzew at apache.org>
> wrote:
>
>>
>>
>> On Tue, Jul 14, 2015 at 4:28 PM, Luke Holmquist <lholmqui at redhat.com>
>> wrote:
>>
>>> JIRA'd https://issues.jboss.org/browse/AGPUSH-1468
>>>
>>>
>>> Matzew,  so for versioning of the node-sender,  i wonder if we should
>>> add that "component" in the versions for JIRA similar to how sps has it's
>>> own versioning scheme.  something like node-sender-0.7.0 ,
>>>  node-sender-0.8.0 ? something like that,  would be easier to keep track of
>>> those releases.
>>>
>>> as i was writing this,  i'm also thinking if these issues should be part
>>> of AG-JS and i can do the versions there?  hmmm
>>>
>>
>> yeah - actually, I think you are right. I am absolutely fine w/ having
>> the node-js-sender on AGJS.
>>
>> It's been a) a fairly stable component (lholmquist++) and b) our APIs are
>> mostly JSON payload to a well-known endpoint - so not much to 'plan' from a
>> AGPUSH / UPS perspective
>>
>
> ok,  sounds good.  I will start adding things over there
>
>>
>> -M
>>
>>
>>>
>>>
>>> On Tue, Jul 14, 2015 at 8:56 AM, Fink, Miles <mfink at email.unc.edu>
>>> wrote:
>>>
>>>>  I'll see if I can’t get it in JIRA.  Just to clarify, the issue I
>>>> noticed regarding empty arrays was on the 0.7.x branch of Node Sender,  so
>>>> it may not be an issue in the latest branch.
>>>>
>>>>  -Miles
>>>>
>>>>   From: Matthias Wessendorf <matzew at apache.org>
>>>> Reply-To: AeroGear Developer Mailing List <aerogear-dev at lists.jboss.org
>>>> >
>>>> Date: Tuesday, July 14, 2015 at 4:51 AM
>>>>
>>>> To: AeroGear Developer Mailing List <aerogear-dev at lists.jboss.org>
>>>> Subject: Re: [aerogear-dev] UPS Node Sender client categories issue?
>>>>
>>>>   Miles,Luke
>>>>
>>>>  mind filing a JIRA issue for this ?
>>>>
>>>> On Thu, Jul 9, 2015 at 8:27 PM, Luke Holmquist <lholmqui at redhat.com>
>>>> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Jul 9, 2015 at 2:15 PM, Fink, Miles <mfink at email.unc.edu>
>>>>> wrote:
>>>>>
>>>>>>  Thanks Luke. Using 0.7.0 version worked.
>>>>>>
>>>>>>  I will note a couple items:
>>>>>>
>>>>>>  0.8.x uses application*Id* (note Id), .0.7.x uses application*ID*
>>>>>>
>>>>>>  Also, I was sending empty arrays for the settings.criteria that I
>>>>>> wasn’t using (deviceType, alias) which then still sent the notification to
>>>>>> all installations regardless of the categories I was sending. After I
>>>>>> removed all the empty arrays from criteria and just sent the categories
>>>>>> array it worked!
>>>>>>
>>>>>
>>>>>  thanks for that input.  sounds like a Bug!
>>>>>
>>>>>>
>>>>>>  Anyway, thanks for the support! Much appreciated!
>>>>>>
>>>>>>  Cheers,
>>>>>> Miles
>>>>>>
>>>>>>
>>>>>>   From: Luke Holmquist <lholmqui at redhat.com>
>>>>>> Reply-To: AeroGear Developer Mailing List <
>>>>>> aerogear-dev at lists.jboss.org>
>>>>>> Date: Thursday, July 9, 2015 at 1:32 PM
>>>>>> To: AeroGear Developer Mailing List <aerogear-dev at lists.jboss.org>
>>>>>> Subject: Re: [aerogear-dev] UPS Node Sender client categories issue?
>>>>>>
>>>>>>   So i see you are using the 1.0.3 version of the UPS,  could you
>>>>>> try the 0.7.0 version of the node-sender and see if that works.
>>>>>>
>>>>>>  The 0.8.x series is targeted for the 1.1.x UPS series which has had
>>>>>> some message format changes
>>>>>>
>>>>>> On Thu, Jul 9, 2015 at 1:28 PM, Luke Holmquist <lholmqui at redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>>> hey Miles,
>>>>>>>
>>>>>>>  Thanks for using the UPS!!
>>>>>>>
>>>>>>>  so i think what your seeing is probably similar to this issue,
>>>>>>> https://issues.jboss.org/browse/AGPUSH-1459
>>>>>>>
>>>>>>>
>>>>>>>  The Dashboard uses the Java Client Sender, so something is going
>>>>>>> on with the node one then
>>>>>>>
>>>>>>>  thanks for putting your versions you are using, that should help
>>>>>>> narrow down things
>>>>>>>
>>>>>>>
>>>>>>>  -Luke
>>>>>>>
>>>>>>>
>>>>>>>  On Thu, Jul 9, 2015 at 1:22 PM, Fink, Miles <mfink at email.unc.edu>
>>>>>>> wrote:
>>>>>>>
>>>>>>>>   Hi,
>>>>>>>>
>>>>>>>>  I’m just starting out with UPS (which is awesome btw!) and the
>>>>>>>> Node.js sender client. One thing I’ve noticed is that a message sent from
>>>>>>>> the dashboard with a particular category is sent to only those
>>>>>>>> installations that have that category listed. This works great and is
>>>>>>>> expected. I’m glad there is a way to target specific notification channels,
>>>>>>>> etc.
>>>>>>>>
>>>>>>>>  Sending a notification via the Node Sender client however appears
>>>>>>>> to be sending to everyone’s installation regardless of the categories sent
>>>>>>>> with the message. Here’s a pastie of what my node client call looks like:
>>>>>>>> http://pastie.org/10282358
>>>>>>>>
>>>>>>>>  I’m using:
>>>>>>>> Unifiedpush Node Sender version 0.8.0-beta1
>>>>>>>>
>>>>>>>>  UPS is the setup via the openshift cartridge, from
>>>>>>>> https://cartreflect-claytondev.rhcloud.com/reflect?github=aerogear/openshift-origin-cartridge-aerogear-push
>>>>>>>>
>>>>>>>>
>>>>>>>>  Any pointers would be greatly appreciated. Very well could be me
>>>>>>>> doing it wrong… ;-)
>>>>>>>>
>>>>>>>>  Thanks,
>>>>>>>> Miles
>>>>>>>>
>>>>>>>>  _______________________________________________
>>>>>>>> aerogear-dev mailing list
>>>>>>>> aerogear-dev at lists.jboss.org
>>>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> aerogear-dev mailing list
>>>>>> aerogear-dev at lists.jboss.org
>>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> aerogear-dev mailing list
>>>>> aerogear-dev at lists.jboss.org
>>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>>
>>>>
>>>>
>>>>
>>>>  --
>>>> Matthias Wessendorf
>>>>
>>>> blog: http://matthiaswessendorf.wordpress.com/
>>>> sessions: http://www.slideshare.net/mwessendorf
>>>> twitter: http://twitter.com/mwessendorf
>>>>
>>>> _______________________________________________
>>>> aerogear-dev mailing list
>>>> aerogear-dev at lists.jboss.org
>>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>>
>>>
>>>
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20150715/ee199161/attachment.html 