[aerogear-dev] broken push notification in UPS 1.1.3.Final

[Matthias Wessendorf]

On Fri, Jul 22, 2016 at 11:19 AM, mischa <mischa.neumann at init.de> wrote:

> Matthias Wessendorf wrote
> > On Fri, Jul 22, 2016 at 10:42 AM, mischa &lt;
>
> > mischa.neumann@
>
> > &gt; wrote:
> >
> >> Matthias Wessendorf wrote
> >> > Ah, I think the delegate is the issue; because it lacks the FCM topic
> >> code
> >> > from Android SDK
> >>
> >> we had no problems with aerogear-unifiedpush-server-1.2.0-alpha.1
> >> and not when naming the variants with
> >>
> >
> > 1.1.2 and 1.2.0-alpha.1 is not containing FCM
> >
> >
> >> aerogear-unifiedpush-server-1.1.3.Final
> >>
> >
> > but FCM is included in 1.1.3 and master (1.2.0-alpha.2-SNAPSHOT)
> >
> >
> > FCM registration is done here:
> >
> https://github.com/aerogear/aerogear-android-push/blob/master/aerogear-android-push/src/main/java/org/jboss/aerogear/android/unifiedpush/fcm/AeroGearFCMPushRegistrar.java#L186-L191
> >
> > But... I wonder... if we can, or should, do something about that on the
> > srver side... hrm...
>
> I see:
>     ... Sent push notification to GCM topic: &#x2F;topics&#x2F;PRODUCTS ...
> and as no client didn't register with the help of aerogear-android-push for
> this topic at Firebase, it wouldn't get any notifications.
>
> then the frontend message "X receivers" is misleadingly as one receiver is
> a
> FCM topic channel :-)
>

yeah, that's something we need to fix - I am not happy w/ that too


>
> and it's not clear, why the UPS is behaving differently when the android
> variant is directly targeted in the push request.
>

because, than we don't do the topic :) we do direct device tokens:
https://github.com/aerogear/aerogear-unifiedpush-server/blob/1.1.3.Final/push/sender/src/main/java/org/jboss/aerogear/unifiedpush/message/token/TokenLoader.java#L129
https://github.com/aerogear/aerogear-unifiedpush-server/blob/1.1.3.Final/push/sender/src/main/java/org/jboss/aerogear/unifiedpush/message/token/TokenLoaderUtils.java#L82

So... we have some hooks to not go w/ FCM topics..... but I hate to
introduce a flag to not use FCM topics.....
So, perhaps for you guys, just send a few request w/ variants tagged?
instead of one - that would work - and will continue to work :D



> Mischa
>
>
>
> --
> View this message in context:
> http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-broken-push-notification-in-UPS-1-1-3-Final-tp12629p12643.html
> Sent from the aerogear-dev mailing list archive at Nabble.com.
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
twitter: http://twitter.com/mwessendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20160722/f92b41f5/attachment.html