[aerogear-dev] Possible bug in getting windows variant with the REST API

[Matthias Wessendorf]

that... sounds like a bug ... no ?


On Fri, May 13, 2016 at 4:12 PM, Luke Holmquist <lholmqui at redhat.com> wrote:

>
>
> On Fri, May 13, 2016 at 10:04 AM, Matthias Wessendorf <matzew at apache.org>
> wrote:
>
>> variant type?
>>
>> we have two different type for Windows (WP8 / 10) - use different push
>> (yes...)
>>
>>
>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/model/api/src/main/java/org/jboss/aerogear/unifiedpush/api/VariantType.java#L41-L49
>>
>
> yup,  i know :)
>
> so in this scenario my endpoint would then look like this:
> http://locationofmyups/rest/applications/
> 5d77107a-3624-4456-a8fa-37036274ff61/windows_wns/
> <http://locationofmyups/rest/applications/%7BPUSHAPPID%7D/%7BTYPE%7D>
>
> which should return 1 variant, but it does not,
> <http://locationofmyups/rest/applications/%7BPUSHAPPID%7D/%7BTYPE%7D>
>
>
>>
>>
>> On Fri, May 13, 2016 at 3:10 PM, Luke Holmquist <lholmqui at redhat.com>
>> wrote:
>>
>>> Currently using what is in master.
>>>
>>>
>>> I've started to implement the GETing of variants for the node admin
>>> client i posted earlier about and i think i might have run into a bug when
>>> trying to get the Windows Variants.
>>>
>>> here is a gist of what my current applications/variants looks like as
>>> JSON:
>>> https://gist.github.com/lholmquist/44134f825373a5bce99624ac3d82c234
>>>
>>> you will see i have 2 variants, one android and the other is a
>>> windows_wns type.
>>>
>>> using the endpoint "
>>> http://locationofmyups/rest/applications/{PUSHAPPID}/{TYPE}" for
>>> android, i get what i'm expecting,  but when i do the windows one, dont get
>>> anything returned
>>>
>>> i'm actually running my ups locally, so i'm able to set a break point,
>>> and it does break in the windows GET code here
>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/WindowsVariantEndpoint.java#L95
>>>
>>> stepping through the getVariantsByType function,
>>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AbstractVariantEndpoint.java#L135
>>>
>>> i noticed that the "type" variable here is of "class
>>> org.jboss.aerogear.unifiedpush.api.WindowsVariant"
>>>
>>> and the variant.getClass() is actually
>>> org.jboss.aerogear.unifiedpush.api.WindowsWNSVariant
>>>
>>> which is making the comparison fail and not return anything.
>>>
>>> So is this a bug,  or do i need to pass something else in to make this
>>> work,
>>>
>>>
>>> note:  i've created all the applications and variants from the admin UI
>>> screens
>>>
>>> _______________________________________________
>>> aerogear-dev mailing list
>>> aerogear-dev at lists.jboss.org
>>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>>
>>
>>
>>
>> --
>> Matthias Wessendorf
>>
>> blog: http://matthiaswessendorf.wordpress.com/
>> sessions: http://www.slideshare.net/mwessendorf
>> twitter: http://twitter.com/mwessendorf
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20160513/b13d3857/attachment-0001.html