[aerogear-dev] Variant Updates return 200 but docs say 204

Luke Holmquist lholmqui at redhat.com
Thu May 19 16:10:47 EDT 2016


On Thu, May 19, 2016 at 4:09 PM, Matthias Wessendorf <matzew at apache.org>
wrote:

> we changed that last year:
> https://github.com/aerogear/aerogear-unifiedpush-server/pull/651
>

i thought it sounded familiar

>
>
> Systems that integrate with the UPS might appreciate the actual response
> data of the updated entity, so we moved to 200 status code.
>
> The doc is broken. Good find Luke.
>
> Mind sending a doc patch ?
>

Doc Patch incoming

>
> On Thu, May 19, 2016 at 9:21 PM, Luke Holmquist <lholmqui at redhat.com>
> wrote:
>
>> The variant update endpoint returns a 200 with the updated content, but
>> the docs says it should return a 204 with no Content
>>
>> i've create a JIRA for it,  https://issues.jboss.org/browse/AGPUSH-1635
>>
>>
>> I think PUT's are suppose to be 204's, but there might be things relying
>> on the fact that the update returns data,
>>
>> here is a link to the AndroidVariants update endpoint,
>> https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AndroidVariantEndpoint.java#L142
>>
>> _______________________________________________
>> aerogear-dev mailing list
>> aerogear-dev at lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
> _______________________________________________
> aerogear-dev mailing list
> aerogear-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/aerogear-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.jboss.org/pipermail/aerogear-dev/attachments/20160519/7a0f0532/attachment.html 


More information about the aerogear-dev mailing list