To help clarify the options here the following gist contains examples of the two suggestions provided so far:<div><a href="https://gist.github.com/4066691">https://gist.github.com/4066691</a><br></div><div><br></div><div><br>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On 13 November 2012 16:49, Daniel Bevenius <span dir="ltr"><<a href="mailto:daniel.bevenius@gmail.com" target="_blank">daniel.bevenius@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">><span style="font-family:arial,sans-serif;font-size:13px">i dislike xml configuration files, so i would vote for an Annotation. </span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px">Yeah, I agree and we are avoiding any xml right now. </span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px">So, how about we provide some hopefully good defaults for CORS and then users can provide there own @Producer. We will provide at builder api to create the config instance so it won't be a lot of work for users. </span></div>
<div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Should CORS be enabled by default? </span></div><div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><br>
<div class="gmail_quote">On 13 November 2012 13:35, Lucas Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div><div><div>On Nov 13, 2012, at 4:18 AM, Daniel Bevenius <<a href="mailto:daniel.bevenius@gmail.com" target="_blank">daniel.bevenius@gmail.com</a>> wrote:</div>
<br><blockquote type="cite">I'm working on adding CORS support there are several things that can be configured in this case. Below is an example of the options that are currently available:<div><p><span>public</span> <span>interface</span> CorsConfiguration {</p>
<p> <span>public</span> <span>abstract</span> <span>boolean</span> isCorsSupportEnabled();</p><p> <span>public</span> <span>abstract</span> <span>boolean</span> exposeHeaders();</p><p> <span>public</span> <span>abstract</span> String getExposeHeaders();</p>
<p><span> </span>public<span> </span>abstract<span> </span>boolean<span> anyOrigin();</span></p><p> <span>public</span> <span>abstract</span> <span>boolean</span> allowCookies();</p><p><span> </span>public<span> </span>abstract<span> </span>boolean<span> hasMaxAge();</span></p>
<p> <span>public</span> <span>abstract</span> <span>long</span> getMaxAge();</p><p> <span>public</span> <span>abstract</span> Set<String> getValidRequestMethods();</p><p> <span>public</span> <span>abstract</span> Set<String> getValidRequestHeaders();</p>
<p>}</p><p>How do we want users to configure these configuration options? Using a CDI annotation with "sensible" default values or specify them in web.xml?</p><div><br></div></div></blockquote><div><br></div></div>
</div><div>i dislike xml configuration files, so i would vote for an Annotation. but thats personal preference</div><div><br></div><br><blockquote type="cite"><div><p>cheers, </p><p>
/Dan</p><p><br></p><p><br></p></div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</blockquote></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div>