Hi firends,<div>My preference goes for XML config. CORS is more a "external" config aspect rather than being part of the "domain/core".</div><div>Seb</div><div><br></div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Wed, Nov 14, 2012 at 12:26 PM, Bruno Oliveira <span dir="ltr"><<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi my friend, at first glance looks like the XML option is more readable.<br>
<br>
But before we move forward I'd like to hear more opinions about it.<br>
<br>
<br>
--<br>
"The measure of a man is what he does with power" - Plato<br>
-<br>
@abstractj<br>
-<br>
Volenti Nihil Difficile<br>
<div class="im"><br>
<br>
<br>
On Tuesday, November 13, 2012 at 2:15 PM, Daniel Bevenius wrote:<br>
<br>
> To help clarify the options here the following gist contains examples of the two suggestions provided so far:<br>
> <a href="https://gist.github.com/4066691" target="_blank">https://gist.github.com/4066691</a><br>
><br>
><br>
><br>
><br>
</div><div class="im">> On 13 November 2012 16:49, Daniel Bevenius <<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a> (mailto:<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a>)> wrote:<br>
> > > i dislike xml configuration files, so i would vote for an Annotation.<br>
> ><br>
> > Yeah, I agree and we are avoiding any xml right now.<br>
> > So, how about we provide some hopefully good defaults for CORS and then users can provide there own @Producer. We will provide at builder api to create the config instance so it won't be a lot of work for users.<br>
> ><br>
> > Should CORS be enabled by default?<br>
> ><br>
> ><br>
</div>> > On 13 November 2012 13:35, Lucas Holmquist <<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a> (mailto:<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a>)> wrote:<br>
<div class="im">> > ><br>
> > > On Nov 13, 2012, at 4:18 AM, Daniel Bevenius <<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a> (mailto:<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a>)> wrote:<br>
> > > > I'm working on adding CORS support there are several things that can be configured in this case. Below is an example of the options that are currently available:<br>
> > > > public interface CorsConfiguration {<br>
> > > > public abstract boolean isCorsSupportEnabled();<br>
> > > > public abstract boolean exposeHeaders();<br>
> > > > public abstract String getExposeHeaders();<br>
> > > > public abstract boolean anyOrigin();<br>
> > > > public abstract boolean allowCookies();<br>
> > > > public abstract boolean hasMaxAge();<br>
> > > > public abstract long getMaxAge();<br>
> > > > public abstract Set<String> getValidRequestMethods();<br>
> > > > public abstract Set<String> getValidRequestHeaders();<br>
> > > > }<br>
</div>> > > > How do we want users to configure these configuration options? Using a CDI annotation with "sensible" default values or specify them in web.xml (<a href="http://web.xml" target="_blank">http://web.xml</a>)?<br>
<div class="im">> > ><br>
> > ><br>
> > > i dislike xml configuration files, so i would vote for an Annotation. but thats personal preference<br>
> > ><br>
> > ><br>
> > > > cheers,<br>
> > > > /Dan<br>
> > > ><br>
> > > ><br>
> > > > _______________________________________________<br>
> > > > aerogear-dev mailing list<br>
</div>> > > > <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> (mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>)<br>
<div class="im">> > > > <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> > ><br>
> > ><br>
> > ><br>
> > > _______________________________________________<br>
> > > aerogear-dev mailing list<br>
</div>> > > <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> (mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>)<br>
<div class="im">> > > <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> ><br>
><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
</div>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> (mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>)<br>
<div class="HOEnZb"><div class="h5">> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br></div>