<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 02/11/2013 10:15 AM, Kris Borchers
wrote:<br>
</div>
<blockquote
cite="mid:45D72D8D-84BE-44F8-A6CF-3581AFC00C06@redhat.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
In <a moz-do-not-send="true"
href="https://issues.jboss.org/browse/AEROGEAR-858">https://issues.jboss.org/browse/AEROGEAR-858</a>,
I propose a change to the APIs of both Pipeline and Auth when
creating new pipes or auth modules. </blockquote>
From a design perspective I don't really understand how inverting
the relationship between Pipes and Auth works.
Authorization/Authentication tokens are part of the request. Pipes
create/manage requests ergo they need to know about what auth is
available. Authentication doesn't care what requests use it, it is
just data.<br>
<br>
Furthermore, looking down the road when we have OAuth, having
Authenticators be a propery on Pipes allows the Pipe to refresh
tokens as part of a read/save/etc request transparently to the
user. <br>
<blockquote
cite="mid:45D72D8D-84BE-44F8-A6CF-3581AFC00C06@redhat.com"
type="cite">What this change does is change the dependency from
Pipeline depending on Auth to only the Auth rest adapter depending
on Pipeline. So what does this get us?
<div><br>
<div>
<ol class="MailOutline">
<li>A narrower dependency between Auth and Pipeline</li>
</ol>
</div>
</div>
</blockquote>
But a wider dependency on Pipes from Auth. Now when an auth is
created it adds new behaviour to every instance of a pipe passed to
it. This exact behaviour can't be done in Java, so Pipe in Java
will still have the dependency on Auth.<br>
<blockquote
cite="mid:45D72D8D-84BE-44F8-A6CF-3581AFC00C06@redhat.com"
type="cite">
<div>
<div>
<ol class="MailOutline">
<li>Removal of AeroGear.ajax and instead build directly on
top of jQuery.ajax which in turn gives us a much smaller
file size (important for JS)</li>
</ol>
</div>
</div>
</blockquote>
I'm not seeing how this requires Auth to be moved.<br>
<blockquote
cite="mid:45D72D8D-84BE-44F8-A6CF-3581AFC00C06@redhat.com"
type="cite">
<div>
<div>
<div><br>
</div>
</div>
</div>
<div>I would appreciate other thoughts on this. There are some
issues with my current PR (<a moz-do-not-send="true"
href="https://github.com/aerogear/aerogear-js/pull/21">https://github.com/aerogear/aerogear-js/pull/21</a>)
but I think I have solutions so once I update that PR I would
appreciate feedback on that as well.</div>
</blockquote>
<br>
<blockquote
cite="mid:45D72D8D-84BE-44F8-A6CF-3581AFC00C06@redhat.com"
type="cite">
<div><br>
</div>
<div>Thanks!</div>
</blockquote>
Don't thank me yet ;)<br>
<blockquote
cite="mid:45D72D8D-84BE-44F8-A6CF-3581AFC00C06@redhat.com"
type="cite">
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
aerogear-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></pre>
</blockquote>
<br>
</body>
</html>