<div dir="ltr">Hey Seb, <div><br></div><div style><span style="color:rgb(0,0,0);font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:13px;line-height:17px;background-color:rgb(240,240,240)">Support for types other than String were actually implemented in the past but, it was decided to not add such support in favour of promoting the usage of Java types (excluding the primitive wrappers). But requirements can change, and perhaps this should be discussed again.</span><br>
</div><div style><font color="#000000" face="Arial, FreeSans, Helvetica, sans-serif"><span style="line-height:17px">The motivation for adding before was the same as your second argument, that it would be easier to use existing classes with aerogear controller. I'd like to see this feature added for this reason. </span></font></div>
<div style><font color="#000000" face="Arial, FreeSans, Helvetica, sans-serif"><span style="line-height:17px"><br></span></font></div><div style><font color="#000000" face="Arial, FreeSans, Helvetica, sans-serif"><span style="line-height:17px">/Dan</span></font></div>
<div style><font color="#000000" face="Arial, FreeSans, Helvetica, sans-serif"><span style="line-height:17px"><br></span></font></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 12 March 2013 15:14, Sebastien Blanc <span dir="ltr"><<a href="mailto:scm.blanc@gmail.com" target="_blank">scm.blanc@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<div>I'm currently working on scaffolding AG-controller stuff and for that I'm relying on the REST endpoints generated by the forge REST plugin. A typical method's signature of a generated endpoint looks like that :</div>
<div><br></div><div><div><b>public Response findById(Long id)</b></div></div><div><br></div><div>But an AG Controller route definition can't point to such a target method since it only support Strings as parameters : </div>
<div><br></div><div><b>route().from("/customers/{id}").on(RequestMethod.GET).consumes(JSON).produces(JSON).to(CustomerEndpoint.class).findById(param("id"));</b></div><div><b><br></b></div><div>Of course, the quick workaround would be to change the signature of the endpoint to :</div>
<div><br></div><div><b>public Response findById(String id)</b></div><div><b><br></b></div><div>But, in my particular case, after the scaffolding happens I can't really tell the developers : "Well, now you have to change manually all the signature of your endpoints and convert your Strings to Longs". </div>
<div>Another use case could be an application having existing endpoints used by a Application A and we introduce Application B using AG controller. More generally, I think it would be a nice addition to AG controller.</div>
<div><br></div><div>I've already proposed a pull request[1] that can't handle all the types which have a constructor with a single String parameter : Long, Integer, BigDecimal, etc ... And also added unit tests to be sure I doesn't break</div>
<div><br></div><div>Feedback is more than welcome ! </div><div><br></div><div>Seb</div><div>[1] <a href="https://github.com/aerogear/aerogear-controller/pull/55" target="_blank">https://github.com/aerogear/aerogear-controller/pull/55</a></div>
<div><br></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>