<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 03/20/2013 09:01 AM, Christos
Vasilakis wrote:<br>
</div>
<blockquote
cite="mid:0C32E693-AE4A-4336-BAEC-FC5716490F8B@gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
nice guides!
<div>
<div><br>
</div>
<div>some small comments:</div>
<div><br>
</div>
<div>In <b>AerogearAndroidPipes101.asciidoc</b></div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span></div>
<div>- Android’s Loader API --> a link to the official
android doc: <a moz-do-not-send="true"
href="http://developer.android.com/guide/components/loaders.html">http://developer.android.com/guide/components/loaders.html</a></div>
<div><span class="Apple-tab-span" style="white-space:pre"> </span></div>
<div>- On the paragraph describing the Loader API I think it's
good to append the added benefit AeroGear provides to the
loader API e.g.</div>
<div>"AeroGear transparently handles the registration and
attaching of the callback in the Loader mechanism, without
the user having to explicitly declare it"…or sth similar.</div>
<div><br>
</div>
<div>---</div>
<div>
<div>In <b>AerogearAndroidPagination.asciidoc</b></div>
<div><br>
</div>
<div>- new PageConsumer()) ? -> did you mean "new
SamplePageResultExtractor()"</div>
</div>
</div>
</blockquote>
I did. Good catch.<br>
<blockquote
cite="mid:0C32E693-AE4A-4336-BAEC-FC5716490F8B@gmail.com"
type="cite">
<div>
<div>
<div><br>
</div>
<div>- typos and comma: ...special requirements or legacy
services, AeroGear's pagination framework can be easily
extended to support them.</div>
</div>
</div>
</blockquote>
Yeah I havn't proofread for grammr/spelling/etc yet.<br>
<blockquote
cite="mid:0C32E693-AE4A-4336-BAEC-FC5716490F8B@gmail.com"
type="cite">
<div>
<div><br>
</div>
<div>---</div>
<div><br>
</div>
<div>In <b>AerogearAndroidDataStore.asciidoc</b></div>
<div><br>
</div>
<div>- Creating a Memory Store</div>
<div> .....Also it can not perform nested querying of its data.
<b>-></b> Note that currently, it doesn't support nested
querying of its data.</div>
<div><br>
</div>
<div>- Creating a SQLStore</div>
<div> not sure if nested querying is supported,</div>
<div> <b> if it does</b> -> Unlike MemoryStore, the
SQLStore supports nested query of its data.</div>
<div> <b>if not</b> -> Similar to MemoryStore, the
SQLStore doesn't support nested query of its data.</div>
<div><br>
</div>
<div>- typo: can conly filter -> can only filter</div>
</div>
</blockquote>
Yeah, maybe I should drop the talk of flitering all together since
it was removed from the spec.<br>
<blockquote
cite="mid:0C32E693-AE4A-4336-BAEC-FC5716490F8B@gmail.com"
type="cite">
<div>
<div><br>
</div>
<div>In <b>AerogearAndroidAuthentication.asciidoc</b></div>
<div><b><br>
</b></div>
<div>- typo: encapuslates -> encapsulates, instanciate
-> instantiate</div>
</div>
</blockquote>
Thanks<br>
<blockquote
cite="mid:0C32E693-AE4A-4336-BAEC-FC5716490F8B@gmail.com"
type="cite">
<div>
<div><br>
</div>
<div>In <b>AerogearAndroidCustomizingPipes.asciidoc</b></div>
<div><b><br>
</b></div>
<div>- ...managing PipeHandler instances and returning their
results and returning them to the user via callbacks.. <b>-> </b></div>
<div> ...managing PipeHandler instances, processing their
results and returning them to the user via callbacks..</div>
<div><br>
</div>
<div>- thustly?</div>
</div>
</blockquote>
Typo, should be thusly. (it means the next blob of stuff is an
example of what I am talking about or the conclusions to be drawn
from what I was just saying). Probably not a particularly common
word. <br>
<blockquote
cite="mid:0C32E693-AE4A-4336-BAEC-FC5716490F8B@gmail.com"
type="cite">
<div>
<div><br>
</div>
<div><br>
</div>
<div>Thanks</div>
<div>Christos</div>
<div><br>
</div>
<div><br>
</div>
<div>
<div>
<div>On Mar 20, 2013, at 10:44 AM, Matthias Wessendorf <<a
moz-do-not-send="true" href="mailto:matzew@apache.org">matzew@apache.org</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">Howdy,
<div><br>
</div>
<div>great to see some docs/guides</div>
<div><br>
</div>
<div>Here are my first/initial comments:</div>
<div><br>
</div>
<div>
<div>1) Group them into a subfolder, like daniel did,
for the controller</div>
<div>
<br>
</div>
<div>2) links to the matching JavaDocs (classes (e.g.
PipeHandlert etc)) does not hurt</div>
<div><br>
</div>
<div>3) not sure about if the
`AerogearAndroidCustomizingPipes.asciidoc` is really
useful ...</div>
<div>
<br>
</div>
<div>"AerogearAndroidPagination"</div>
<div>4) You never show ParameterProvider...</div>
<div>5) what is config.setDataRoot()</div>
<div>--> looks like the Android bits are a bit
_different_, compared to the iOS/JS version </div>
<div>6) do I really have to implement my own
"PageResultExtractor" </div>
<div><br>
</div>
<div>The Pagination feels: Lot's of code... for a simple
read...</div>
<div><br>
</div>
</div>
<div><br>
</div>
<div><br>
</div>
<div>-Matthias</div>
<div><br>
<div><br>
<div class="gmail_quote">On Tue, Mar 19, 2013 at 9:19
PM, Summers Pittman <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:supittma@redhat.com"
target="_blank">supittma@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I just
committed some guides for using the Aerogear
Android libraries. <br>
<br>
<a moz-do-not-send="true"
href="https://github.com/aerogear/aerogear.org/commit/d3cae265d"
target="_blank">https://github.com/aerogear/aerogear.org/commit/d3cae265d</a><br>
<br>
<br>
I'm still editing them for
gramma/spelling/formatting, so be warned (hence
why I havn't PRed it yet). Also, if there is
anything I missed, glossed over, explained like
crap let me know and I will try to reword it
when I begin proofreading.<span class="HOEnZb"><font
color="#888888"><br>
<br>
Summers<br>
</font></span></div>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a moz-do-not-send="true"
href="https://lists.jboss.org/mailman/listinfo/aerogear-dev"
target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Matthias Wessendorf <br>
<br>
blog: <a moz-do-not-send="true"
href="http://matthiaswessendorf.wordpress.com/"
target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a moz-do-not-send="true"
href="http://www.slideshare.net/mwessendorf"
target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a moz-do-not-send="true"
href="http://twitter.com/mwessendorf"
target="_blank">http://twitter.com/mwessendorf</a>
</div>
</div>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote>
</div>
<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
aerogear-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></pre>
</blockquote>
<br>
</body>
</html>