<br><br><div class="gmail_quote">On Thu, Mar 21, 2013 at 7:57 PM, Summers Pittman <span dir="ltr"><<a href="mailto:supittma@redhat.com" target="_blank">supittma@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div class="im">
<div>On 03/20/2013 04:44 AM, Matthias
Wessendorf wrote:<br>
</div>
<blockquote type="cite">Howdy,
<div><br>
</div>
<div>great to see some docs/guides</div>
<div><br>
</div>
<div>Here are my first/initial comments:</div>
<div><br>
</div>
<div>
<div>1) Group them into a subfolder, like daniel did, for the
controller</div>
</div>
</blockquote></div>
+1<div class="im"><br>
<blockquote type="cite">
<div>
<div>
<br>
</div>
<div>2) links to the matching JavaDocs (classes (e.g.
PipeHandlert etc)) does not hurt</div>
</div>
</blockquote></div>
+1<div class="im"><br>
<blockquote type="cite">
<div>
<div><br>
</div>
<div>3) not sure about if the
`AerogearAndroidCustomizingPipes.asciidoc` is really useful
...</div>
</div>
</blockquote></div>
I disagree. It may be titled wrong, but knowing how the Android
library implements Pipes and how to extend this implementations for
your own end is quite useful.<br>
<br>
At least that is the goal of the doc, what did you see differently?<div class="im"><br>
<br>
<blockquote type="cite">
<div>
<div>
<br>
</div>
<div>"AerogearAndroidPagination"</div>
<div>4) You never show ParameterProvider...</div>
</div>
</blockquote></div>
Because the default implementation of Parameter Provider just
consumes data provided by the PageConsumer. Explicitly setting it
isn't necessary.<br>
<br>
<blockquote type="cite">
<div>
<div>5) what is config.setDataRoot()</div>
</div>
</blockquote>
The root of the data you want to operate on as explained in the
Intro document and the API's.<br>
<br>
For example, in the DevNexus result set for speakers you have <br>
<br>
{<br>
speakers : {<br>
data:[<br>
{speaker1}, <br>
{speaker2}<br>
]<br>
}<br>
}<br>
<br>
The "list" of data you are asking for actually starts at the data
parameter of the speakers parameter.
config.setDataRoot("speakers.data"); makes this explicit.</div></blockquote><div><br></div><div>Hrm - interesting. I think that would be nice thing, generally;</div><div>I guess a bit more open discussions on "features" like that would be good. (thinks: API/SPEC discussions)</div>
<div><br></div><div>Currently, I do not see why this would not be benefit for the JS or iOS library. A heads up would have been a good idea, IMO</div><div><br></div><div>Or... perhaps I just missed it </div><div><br></div>
<div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div class="im"><br>
<br>
<br>
<blockquote type="cite">
<div>
<div>--> looks like the Android bits are a bit _different_,
compared to the iOS/JS version </div>
<div>6) do I really have to implement my own
"PageResultExtractor" </div>
</div>
</blockquote></div>
No unless you are consuming it from a service where the paging
doesn't follow "simple" patterns.<div class="im"><br>
<blockquote type="cite">
<div>
<div>The Pagination feels: Lot's of code... for a simple read...</div>
<div><br>
</div>
</div>
</blockquote></div>
Because the simple read of pagination is linked to at the beginning
for the doc. This is for consuming arbitrary paging from a site.
Perhaps this needs to be an "advanced" doc and I should discuss
simpler paging in an into doc. Like Pipes.<br>
<blockquote type="cite">
<div><br>
</div>
<div><br>
</div>
<div>-Matthias</div>
</blockquote>
Seems like some of the docs might be missing things (an intro read
to paging, more explicit goals of the guid etc).<div class="im"><br>
<blockquote type="cite">
<div><br>
<div><br>
<div class="gmail_quote">On Tue, Mar 19, 2013 at 9:19 PM,
Summers Pittman <span dir="ltr"><<a href="mailto:supittma@redhat.com" target="_blank">supittma@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> I just committed
some guides for using the Aerogear Android libraries. <br>
<br>
<a href="https://github.com/aerogear/aerogear.org/commit/d3cae265d" target="_blank">https://github.com/aerogear/aerogear.org/commit/d3cae265d</a><br>
<br>
<br>
I'm still editing them for gramma/spelling/formatting,
so be warned (hence why I havn't PRed it yet). Also, if
there is anything I missed, glossed over, explained like
crap let me know and I will try to reword it when I
begin proofreading.<span><font color="#888888"><br>
<br>
Summers<br>
</font></span></div>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Matthias Wessendorf <br>
<br>
blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
aerogear-dev mailing list
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></pre>
</blockquote>
<br>
</div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>