<div dir="ltr">Hi Tolis, <div><br></div><div>sorry for not responding earlier. We've been busy with the 1.0.0 release but will take this for a spin after the release is out. </div><div><br></div><div>Thanks,</div><div>
<br></div><div style>/Dan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 23 March 2013 01:21, Apostolos Emmanouilidis <span dir="ltr"><<a href="mailto:aemmanou@redhat.com" target="_blank">aemmanou@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><u></u>
<div>
Hi Karel,<br>
<br>
Thank you for your comments.<br>
<br>
I've removed the parent POM XML, synchronized the forked repository with the original/parent Aerogear-Controller-Demo repository, performed the required actions so that my master branch is ahead of the original/parent Aerogear-Controller-Demo master branch by one commit and finally created a pull request.<br>
<br>
The changes included in the commit are:<br>
<blockquote>
1. Created subfolder aerogear-controller-demo and moved the content of the initial project inside<br>
2. Created subfolder aerogear-controller-demo-ftest which contains the functional test<br>
3. Modified the gitignore file to ignore some files and folders inside the above created subfolders<br>
<br>
</blockquote>
Thank you,<br>
Tolis<div><div class="h5"><br>
<br>
On Fri, 2013-03-22 at 15:15 +0100, Karel Piwko wrote:
<blockquote type="CITE">
<pre>Tolis,
thank you for driving this!
Now a few comments: Having a parent pom is not necessary. As we agreed during
JDF quickstarts discussions, the best way to handle example + test scenario
that is to have no parent at all.
Users will not get confused while importing into JBDS. Power users willing to
see how to test that will simply import a second project. Test project itself is
packaged in aerogear-controller-demo/functional-test so it won't disturb
users with two directories per project.
Karel
On Thu, 21 Mar 2013 22:31:51 +0100
Apostolos Emmanouilidis <<a href="mailto:aemmanou@redhat.com" target="_blank">aemmanou@redhat.com</a>> wrote:
<font color="#737373">> Hi,</font>
<font color="#737373">> </font>
<font color="#737373">> Just wanted to inform you that I've added a functional test for the</font>
<font color="#737373">> Aerogear-Controller-Demo in the GitHub repo [1]</font>
<font color="#737373">> </font>
<font color="#737373">> I created a parent POM which contains 2 modules, the first module is the</font>
<font color="#737373">> aerogear-controller-demo and the second one is the</font>
<font color="#737373">> aerogear-controller-demo-ftest. The aerogear-controller-demo version is</font>
<font color="#737373">> the latest one until the moment I'm writing this e-mail. The only change</font>
<font color="#737373">> which has been done in the aerogear-controller-demo is that the staging</font>
<font color="#737373">> repository was added inside the POM xml since I didn't want to modify my</font>
<font color="#737373">> maven settings.xml. But we can change it..</font>
<font color="#737373">> </font>
<font color="#737373">> The functional test project contains 2 profiles:</font>
<font color="#737373">> </font>
<font color="#737373">> 1. arq-jbossas-managed-7</font>
<font color="#737373">> 2. arq-jbossas-remote</font>
<font color="#737373">> </font>
<font color="#737373">> </font>
<font color="#737373">> By default the first profile is active.</font>
<font color="#737373">> </font>
<font color="#737373">> Inside the AerogearControllerDemoTestCase there is a TODO task which</font>
<font color="#737373">> states: 'TODO: uncomment when</font>
<font color="#737373">> <a href="https://issues.jboss.org/browse/AEROGEAR-1005" target="_blank">https://issues.jboss.org/browse/AEROGEAR-1005</a> is fixed'. The relevant</font>
<font color="#737373">> commented code tests the above JIRA issue.</font>
<font color="#737373">> </font>
<font color="#737373">> Any comment, enhancement, improvement is highly appreciated :)</font>
<font color="#737373">> </font>
<font color="#737373">> Thank you,</font>
<font color="#737373">> Tolis Emmanouilidis</font>
<font color="#737373">> </font>
<font color="#737373">> [1] <a href="https://github.com/tolis-e/aerogear-controller-demo.git" target="_blank">https://github.com/tolis-e/aerogear-controller-demo.git</a></font>
</pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>