<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Apr 4, 2013 at 8:34 AM, Christos Vasilakis <span dir="ltr"><<a href="mailto:cvasilak@gmail.com" target="_blank">cvasilak@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
<div class="im"><br>
On Apr 3, 2013, at 11:33 PM, Summers Pittman <<a href="mailto:supittma@redhat.com">supittma@redhat.com</a>> wrote:<br>
<br>
> I've submitted 2 PRs. One is for the implementation and the other is for the integration tests.<br>
><br>
> Couple of quick things I want to bring up for comment:<br>
><br>
> 1) I'm using <a href="http://controller-aerogear.rhcloud.com/aerogear-controller-demo" target="_blank">controller-aerogear.rhcloud.com/aerogear-controller-demo</a> as the base url for my tests and a timeout of 1ms. I doubt OpenShift will respond faster than that but it might be nice if we had a tarpit service where the http connection is made but no data is sent to make testing less reliant on swingy behavior. WDYT?<br>
<br>
</div>faced similar issue in the iOS [1], had to create a separate project [2] that blocks the request for some amount of time so I can verify cancel and timeout works correctly. +1 to have this service<br></blockquote><div>
<br></div><div style>I guess that sounds reasonable :)</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
<br>
><br>
> 2) I'm defaulting the timeout to MAX_INT. HttpURLConnection (which does the heavy lifting) disables timeouts if a value of 0 is passed. Should timeout be defaulted to 0 instead? On the one hand I like having timeouts disabled by default, but on the other hand I feel like 0 is a very ambiguous value. MAX_INT very clearly means "don't time out for a very long time". WDYT?<br>
<br>
</div>+1<br></blockquote><div><br></div><div><br></div><div style>+1 here as well</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Thanks,<br>
Christos<br>
<br>
<br>
<br>
[1] <a href="http://lists.jboss.org/pipermail/aerogear-dev/2013-February/001704.html" target="_blank">http://lists.jboss.org/pipermail/aerogear-dev/2013-February/001704.html</a><br>
[2] <a href="https://github.com/cvasilak/RESTfulExample" target="_blank">https://github.com/cvasilak/RESTfulExample</a><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
><br>
> Summers<br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>