<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Although, looking again, this seems to not have been rebased properly. Those commits from abstractj should not be in there with a proper rebase. Looks like maybe a merge was done without rebasing.<div><br><div><div>On May 22, 2013, at 7:43 AM, Kris Borchers <<a href="mailto:kris@redhat.com">kris@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Never mind, after reading a little more carefully, this looks ok.<div><br></div><div>/me goes back to his hole</div><div><br><div><div>On May 22, 2013, at 7:41 AM, Kris Borchers <<a href="mailto:kris@redhat.com">kris@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Can we try to be a little more thorough in our PR review. I may have some picky issues with that PR that I will add comments about now.<div><br><div><div>On May 22, 2013, at 7:37 AM, Sebastien Blanc <<a href="mailto:scm.blanc@gmail.com">scm.blanc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi Erik,<div style="">Thanks for the explanation !</div><div style="">And for everyone : this PR has already been reviewed and merged ! </div><div style="">Seb</div><div style=""><br></div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, May 22, 2013 at 2:28 PM, Erik Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Hi,<div><br></div><div>Just to summarise here is what we found out when trying to create an Errai client for the TODO demo:</div><div><br></div><div><a href="https://github.com/aerogear/TODO/pull/29" target="_blank">https://github.com/aerogear/TODO/pull/29</a></div>
<div><br></div><div>We have our own implementation that serialises JSON from and to objects that is compliant with Jackson and that seems to 'conflict' with the server implementation, because that is receiving Longs as javascript numbers. A number in Javascript is a Double and if you execute the following javascript you'll see that this leads to strange rounding problems </div>
<div><br></div><div><table style="line-height:18px;border-spacing:0px;color:rgb(51,51,51);width:1134px;font-size:13px;font-family:Helvetica,arial,freesans,clean,sans-serif;margin:0px;border:0px;padding:0px"><tbody style="margin:0px;padding:0px;border:0px"><tr style="margin: 0px; padding: 0px; border: 0px; background-color: rgb(221, 255, 221); ">
<td style="margin:0px;padding:0px 10px;border:0px;font-family:Consolas,'Liberation Mono',Courier,monospace;color:rgb(51,51,51);white-space:nowrap;background-color:rgb(248,238,199)"></td></tr><tr style="margin: 0px; padding: 0px; border: 0px; background-color: rgb(221, 255, 221); ">
<td style="margin: 0px; padding: 0px 8px; border-width: 0px 1px 0px 0px; border-right-style: solid; border-color: rgb(180, 226, 180); width: 24px; font-family: Consolas, 'Liberation Mono', Courier, monospace; vertical-align: top; text-align: right; background-color: rgb(206, 255, 206); ">
<br></td><td style="margin: 0px; padding: 0px 8px; border-width: 0px 1px 0px 0px; border-right-style: solid; border-color: rgb(180, 226, 180); width: 24px; font-family: Consolas, 'Liberation Mono', Courier, monospace; vertical-align: top; text-align: right; background-color: rgb(206, 255, 206); ">
<br></td><td style="margin:0px;padding:0px 10px;border:0px;font-family:Consolas,'Liberation Mono',Courier,monospace;color:rgb(51,51,51);white-space:nowrap">var test = {"id":1,"name":"tag","tags":[10000000000000001]};</td>
</tr><tr style="margin: 0px; padding: 0px; border: 0px; background-color: rgb(221, 255, 221); "><td style="margin: 0px; padding: 0px 8px; border-width: 0px 1px 0px 0px; border-right-style: solid; border-color: rgb(180, 226, 180); width: 24px; font-family: Consolas, 'Liberation Mono', Courier, monospace; vertical-align: top; text-align: right; background-color: rgb(206, 255, 206); ">
</td><td style="margin: 0px; padding: 0px 8px; border-width: 0px 1px 0px 0px; border-right-style: solid; border-color: rgb(180, 226, 180); width: 24px; font-family: Consolas, 'Liberation Mono', Courier, monospace; vertical-align: top; text-align: right; background-color: rgb(206, 255, 206); ">
</td><td style="margin:0px;padding:0px 10px;border:0px;font-family:Consolas,'Liberation Mono',Courier,monospace;color:rgb(51,51,51);white-space:nowrap"><b style="padding:0px;border:0px;font-family:'Octicons Regular';display:inline-block;line-height:1;font-size:16px;width:25px;min-height:16px;color:rgb(65,131,196)"></b>console.log(test.tags[0]);</td>
</tr><tr style="margin: 0px; padding: 0px; border: 0px; background-color: rgb(221, 255, 221); "><td style="margin: 0px; padding: 0px 8px; border-width: 0px 1px 0px 0px; border-right-style: solid; border-color: rgb(180, 226, 180); width: 24px; font-family: Consolas, 'Liberation Mono', Courier, monospace; vertical-align: top; text-align: right; background-color: rgb(206, 255, 206); ">
</td><td style="margin: 0px; padding: 0px 8px; border-width: 0px 1px 0px 0px; border-right-style: solid; border-color: rgb(180, 226, 180); width: 24px; font-family: Consolas, 'Liberation Mono', Courier, monospace; vertical-align: top; text-align: right; background-color: rgb(206, 255, 206); ">
</td><td style="margin:0px;padding:0px 10px;border:0px;font-family:Consolas,'Liberation Mono',Courier,monospace;color:rgb(51,51,51);white-space:nowrap"><b style="padding:0px;border:0px;font-family:'Octicons Regular';display:inline-block;line-height:1;font-size:16px;width:25px;min-height:16px;color:rgb(65,131,196)"></b></td>
</tr></tbody></table><div><br></div></div><div><br></div><div>The same exists in Java</div><div><br></div><div><a href="https://gist.github.com/jfuerth/5372442" style="margin:0px;padding:0px;border:0px;color:rgb(65,131,196);text-decoration:none;font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:13px;line-height:22px;background-color:rgb(251,251,251)" target="_blank">https://gist.github.com/jfuerth/5372442</a></div>
<div><br></div><div>What I've added to the server side of the demo is the ability to receive the ids as Strings and then convert them on the server side where such a number limitation does not exists.</div><div><br></div>
<div>Cheers,</div><div><span style="white-space:pre-wrap"> </span>Erik Jan</div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote></div><br></div></div>_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote></div><br></div></div>_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/aerogear-dev</blockquote></div><br></div></body></html>