<div dir="ltr">Hi,<div style>I start looking at the repo. I have some general questions and then more (not that much implementation detailed ;) ) specific proposals</div><div style><br></div><div style>* Is our final goal to propose an implementation that we really want the developers to use or is it more providing a reference implementation of the sender API and developer will most of the time implement their own ? </div>
<div style><br></div><div style>* How are we going to secure the API ? </div><div style><br></div><div style>* The API looks like now "fire & forget", do we plan to change that ? I can imagine that people using the sender need to have some "feedback/return value/response" to manage their flows ?</div>
<div style><br></div><div style>* You say one will go away, why is that ? Do we want to lean toward a single implementation ? We could propose different ones (and in different language, like a vertx mod client)</div><div style>
<br></div><div style>So, now a bit more specific :</div><div style>I've been forking your repo : <a href="https://github.com/sebastienblanc/ag-java-sender/tree/refactoring">https://github.com/sebastienblanc/ag-java-sender/tree/refactoring</a></div>
<div style><br></div><div style>To factor more code and make the sender API really unit testable (running without any server) I've moved a bit things and introduced a sort of Client interface that will implement really the http client we will use, this client is then injected in the sender interface.</div>
<div style>With Arquillian should be easy to add real integration tests.</div><div style><br></div><div class="gmail_extra">Let's discuss !</div><div class="gmail_extra">Sebi</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Jun 3, 2013 at 9:00 PM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">Hello,<div><br></div><div>a FIRST version of the Java Sender API is ready:</div><div><a href="https://github.com/matzew/ag-java-sender" target="_blank">https://github.com/matzew/ag-java-sender</a></div><div>
<br></div><div>Two implementations, based on different Java HTTP clients:</div>
<div>* RestEasy:</div><div><a href="https://github.com/matzew/ag-java-sender/blob/master/src/main/java/org/aerogear/unifiedpush/resteasy/RestEasyJavaSender.java" target="_blank">https://github.com/matzew/ag-java-sender/blob/master/src/main/java/org/aerogear/unifiedpush/resteasy/RestEasyJavaSender.java</a></div>
<div>* AsyncHttpClient:</div><div><a href="https://github.com/matzew/ag-java-sender/blob/master/src/main/java/org/aerogear/unifiedpush/async/AsyncJavaSender.java" target="_blank">https://github.com/matzew/ag-java-sender/blob/master/src/main/java/org/aerogear/unifiedpush/async/AsyncJavaSender.java</a><br>
</div><div><br></div><div>One will go away, time will tell... not important now...<br></div><div><br></div><div>Tests:</div><div><a href="https://github.com/matzew/ag-java-sender/tree/master/src/test/java/org/aerogear/unifiedpush" target="_blank">https://github.com/matzew/ag-java-sender/tree/master/src/test/java/org/aerogear/unifiedpush</a><br>
</div><div><br></div><div><br></div><div>More functionality (e.g. selective send for deviceType, MobileVariant) will follow, hand in hand with the matching endpoints</div><span class=""><font color="#888888"><div><br></div>
<div>
<br></div><div>-Matthias</div><div><br></div><div><br></div><div><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></font></span></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div></div>