<div dir="ltr">merged <a href="https://github.com/aerogear/aerogear-unified-push-server/pull/6">https://github.com/aerogear/aerogear-unified-push-server/pull/6</a><div><br></div><div>thanks</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Wed, Jun 19, 2013 at 7:29 PM, Bruno Oliveira <span dir="ltr"><<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Just to let you know, I opened the following jira<br>
<a href="https://issues.jboss.org/browse/AGSEC-68" target="_blank">https://issues.jboss.org/browse/AGSEC-68</a> and already attached a PR.<br>
<br>
The whole idea is as soon as we on the authorization model, extract it<br>
to AGSEC. I'll also start some unit testing to the endpoints.<br>
<div class="im"><br>
Matthias Wessendorf wrote:<br>
><br>
><br>
><br>
> On Wed, Jun 19, 2013 at 6:15 PM, Bruno Oliveira <<a href="mailto:bruno@abstractj.org">bruno@abstractj.org</a><br>
</div><div><div class="h5">> <mailto:<a href="mailto:bruno@abstractj.org">bruno@abstractj.org</a>>> wrote:<br>
><br>
> I do it, if we're not using the interceptor we're just hiding a issue<br>
> and duplicating code.<br>
><br>
><br>
> I agree on that :)<br>
><br>
><br>
> - Issue: The endpoint should return 401 instead of bad request on<br>
> requests.<br>
><br>
><br>
> correct.<br>
><br>
> So, how about:<br>
> I give it another try tomorrow and will report back ?<br>
><br>
> -Matthias<br>
><br>
><br>
> Matthias Wessendorf wrote:<br>
> > I think I didn't use it, because it throws an RT exception (no<br>
> problem<br>
> > with that), which I could catch on the RestEasy layer.<br>
> > Instead of (for unauthorized invokes) returning 401 (to cURL, for<br>
> > instance), it was just "bad request".<br>
> ><br>
> > So, I went for the "check by code" solution first. Not saying<br>
> that I am<br>
> > AGAINST the interceptor.<br>
> ><br>
> > I think on the long run that would be better and cleaner.<br>
><br>
> --<br>
> abstractj<br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
</div></div>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> <mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>><br>
<div class="HOEnZb"><div class="h5">> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Matthias Wessendorf<br>
><br>
> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
--<br>
abstractj<br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>