<div dir="ltr">any comments ?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jun 25, 2013 at 6:37 PM, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>I noticed that the ctor, currently, takes the entire URL of the "registration" endpoint:</div>
<div><a href="https://github.com/secondsun/PushEEDemo/blob/master/src/com/example/pusheedemo/MainApplication.java#L23" target="_blank">https://github.com/secondsun/PushEEDemo/blob/master/src/com/example/pusheedemo/MainApplication.java#L23</a><br>
</div><div><br></div><div>That's ok, for now. but I think that ideally the application specific part (here "/rest/registry/device") should not be exposed. It could be changed, by PushEE.</div><div>
<br></div><div>In the iOS SDK, we only "require" the URL + the name of the servlet context.</div><div><br></div><div>For instance:</div><div><a href="https://github.com/aerogear/aerogear-push-ios-registration/blob/master/push-sdkTests/AGDeviceRegistrationSpec.m#L47" target="_blank">https://github.com/aerogear/aerogear-push-ios-registration/blob/master/push-sdkTests/AGDeviceRegistrationSpec.m#L47</a><br>
</div><div>(from a "mocked" test)</div><div><br></div><div>So the SDK internally appends the "rest/registry/device":</div><div><a href="https://github.com/aerogear/aerogear-push-ios-registration/blob/master/push-sdk/AGDeviceRegistration.m#L71" target="_blank">https://github.com/aerogear/aerogear-push-ios-registration/blob/master/push-sdk/AGDeviceRegistration.m#L71</a><br>
</div><div><br></div><div>Would you think this is good for the Android-SDK as well ? </div><div><br></div><div><br></div><div>Greetings.</div><span class="HOEnZb"><font color="#888888"><div>Matthias</div><div><br></div><div>
<div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>