<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I don't think we need to go down the AMD path just yet. That said, we already provide a way to do custom builds <a href="http://aerogear.org/download/custom/">http://aerogear.org/download/custom/</a>. The problem is that still doesn't bundle the external deps into the built file. That's one of the points of this thread is whether or not we should. I don't think we should TBH, but I want other opinions.<div><br><div><div>On Jul 8, 2013, at 7:50 AM, Karel Piwko <<a href="mailto:kpiwko@redhat.com">kpiwko@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Just a guess, would not require.js and creating customized Aerogear.js bundle<br>per customer's scenario help here?<br><br>On Mon, 8 Jul 2013 07:03:07 -0500<br>Kris Borchers <<a href="mailto:kris@redhat.com">kris@redhat.com</a>> wrote:<br><br><blockquote type="cite">So I have a dilemma on which I would like input from the team. In<br><a href="https://issues.jboss.org/browse/AGJS-48">https://issues.jboss.org/browse/AGJS-48</a> qmx reports that he gets:<br><br>Uncaught ReferenceError: vertx is not defined at aerogear.js:2627<br><br>when using AeroGear.js in a blank page. The reason for this is that the full<br>build of AeroGear.js contains the new vert.x and STOMP over websocket<br>adapters for Notifier. These adapters have dependencies on vertxbus.js and<br>stomp.js respectively. Since they are not included in the page, you get that<br>error. Here is the dilemma.<br><br>Do I bundle those files into AeroGear.js as part of the build when those<br>adapters are included or not? The reason I did not is because they are<br>external dependencies and I didn't want them bloating the file size just like<br>we do with jQuery. That said, it's obviously easy to not realize you need<br>those files, especially if you grab AeroGear.js and don't intend on using the<br>Notifier bits or just grab it and throw it in a page and see those errors as<br>qmx did.<br><br>Thoughts?<br></blockquote>_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/aerogear-dev<br></blockquote></div><br></div></body></html>