<div dir="ltr">Hi Bruno,<div><br></div><div>I reviewed the bits already separately, as you can tell from my comments :-) </div><div><br></div><div>I think generally it looks very good. Also I am happy to see you went and created a separate module, based on the issues we discovered. :-)</div>
<div><br></div><div><br></div><div>I think, to be used in CDI, perhaps a doc (e.g. README.md) should mention the required Producers?</div><div><br></div><div>Like:</div><div><div>@Produces</div><div> public HawkServer createHawkServer() {</div>
<div> HawkServerConfiguration configuration = new HawkServerConfiguration.Builder().build();</div><div> return new HawkServer.Builder().configuration(configuration).build();</div><div> }</div><div> </div>
<div> @Produces</div><div> public HawkCredentialProvider createHawkCredentialProvider() {</div><div> </div><div> return new HawkCredentialProvider() {</div><div> </div><div> @Override</div><div> public HawkCredentials findByKey(String arg0) {</div>
<div> HawkCredentials credentials = new HawkCredentials.Builder()</div><div> .keyId("dh37fgj492je")</div><div> .key("werxhqb98rpaxn39848xrunpaw3489ruxnpa98w4rxn")</div>
<div> .algorithm(HawkCredentials.Algorithm.SHA256)</div><div> .build();</div><div> return credentials;</div><div> }</div><div> };</div><div> }</div>
</div><div><br></div><div><br></div><div><br></div><div>-Matthias</div><div><br></div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 17, 2013 at 6:11 PM, Bruno Oliveira <span dir="ltr"><<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Good morning all.<br>
<br>
After some feedback on Hawk<br>
(<a href="http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-AeroGear-Security-1-2-0-staged-td4006.html" target="_blank">http://aerogear-dev.1069024.n5.nabble.com/aerogear-dev-AeroGear-Security-1-2-0-staged-td4006.html</a>)<br>
I asked Qmx to create a new repository for Hak and most of the commits<br>
into AeroGear Security were reverted. The latest stable one is still<br>
1.1.1, so if you are using it, you don't need to worry about.<br>
<br>
<br>
The repository created is:<br>
<a href="https://github.com/abstractj/aerogear-security-hawk" target="_blank">https://github.com/abstractj/aerogear-security-hawk</a>, you are free to<br>
test and provide some feedback. Also AG Sec Hawk was staged under<br>
<a href="https://repository.jboss.org/nexus/content/repositories/jboss_releases_staging_profile-1290/" target="_blank">https://repository.jboss.org/nexus/content/repositories/jboss_releases_staging_profile-1290/</a>.<br>
<br>
If you want to test it, please follow the instructions here:<br>
<a href="https://github.com/aerogear/aerogear-controller-demo/pull/66" target="_blank">https://github.com/aerogear/aerogear-controller-demo/pull/66</a> or<br>
<a href="https://github.com/aerogear/aerogear-security/pull/27" target="_blank">https://github.com/aerogear/aerogear-security/pull/27</a>.<br>
<br>
Feedback is welcome.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
abstractj<br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>