<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 07/23/2013 05:17 AM, Matthias
Wessendorf wrote:<br>
</div>
<blockquote
cite="mid:CAAg5f2QaLcBijjtKGDOLmn0kYg1Nq4kFubC+NGz44vq-Bg1krQ@mail.gmail.com"
type="cite">
<div dir="ltr">Hello,
<div><br>
</div>
<div>I have a few question on the 'push' branch:</div>
<div><br>
</div>
<div>1) going over the MessageHandler interface ([1]), am I
right that the "onError()" and "onDeleteMessage()" methods are
only relevant for the "device to cloud" case ?</div>
</div>
</blockquote>
Not exactly. These are handlers for status messages from GCM.
onDeleteMessage is sent to the client when a notification has been
removed from the server. This can be because they notifications are
being batched for instance.<br>
See the GcmBroadcastReceiver sample code for details:
<a class="moz-txt-link-freetext" href="https://developer.android.com/google/gcm/gs.html">https://developer.android.com/google/gcm/gs.html</a><br>
<br>
And the
javadocs:<a class="moz-txt-link-freetext" href="https://developer.android.com/reference/com/google/android/gms/gcm/GoogleCloudMessaging.html#MESSAGE_TYPE_DELETED">https://developer.android.com/reference/com/google/android/gms/gcm/GoogleCloudMessaging.html#MESSAGE_TYPE_DELETED</a><br>
<br>
As far as the error message handler goes, the docs aren't explicit,
but I think I misread it and you are correct. It is a callback for
when an error on the server happens receiving a message from the
client.<br>
<br>
<blockquote
cite="mid:CAAg5f2QaLcBijjtKGDOLmn0kYg1Nq4kFubC+NGz44vq-Bg1krQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<br>
</div>
<div>2) I know it's early work, but I was wondering if we
should (later) rename the 'AGPushMessageReceiver' class
([2]).</div>
<div><br>
</div>
</div>
</div>
</blockquote>
+1 to a rename. <br>
<blockquote
cite="mid:CAAg5f2QaLcBijjtKGDOLmn0kYg1Nq4kFubC+NGz44vq-Bg1krQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>Not sure on a better name, but the AG prefix seems a
little odd :) Perhaps:</div>
<div>
<div>* PushMessageReceiver</div>
</div>
<div>
<div>* AeroGearPushMessageReceiver</div>
</div>
<div>
<div>* GCMMessageReceiver (since this is really "only" GCM
based push messaging)</div>
</div>
<div>* AeroGearGCMMessageReceiver</div>
</div>
</div>
</blockquote>
I like this one.<br>
<blockquote
cite="mid:CAAg5f2QaLcBijjtKGDOLmn0kYg1Nq4kFubC+NGz44vq-Bg1krQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div><br>
</div>
<div>If folks agree on a later rename, I'd create a JIRA to
track this ;-)</div>
</div>
</div>
</blockquote>
<br>
<blockquote
cite="mid:CAAg5f2QaLcBijjtKGDOLmn0kYg1Nq4kFubC+NGz44vq-Bg1krQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div><br>
</div>
<div><br>
</div>
<div>Greetings,</div>
<div>Matthias</div>
<div><br>
</div>
<div>[1] <a moz-do-not-send="true"
href="https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/MessageHandler.java">https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/MessageHandler.java</a></div>
<div>[2] <a moz-do-not-send="true"
href="https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/AGPushMessageReceiver.java">https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/AGPushMessageReceiver.java</a><br
clear="all">
<div><br>
</div>
-- <br>
Matthias Wessendorf <br>
<br>
blog: <a moz-do-not-send="true"
href="http://matthiaswessendorf.wordpress.com/"
target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a moz-do-not-send="true"
href="http://www.slideshare.net/mwessendorf"
target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a moz-do-not-send="true"
href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
aerogear-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>
<a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></pre>
</blockquote>
<br>
</body>
</html>