<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Jul 24, 2013 at 8:12 PM, Kris Borchers <span dir="ltr"><<a href="mailto:kris@redhat.com" target="_blank">kris@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div>
<div>On Jul 24, 2013, at 10:29 AM, Matthias Wessendorf <<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr"><br><div class="gmail_extra">
<br>
<br><div class="gmail_quote">On Wed, Jul 24, 2013 at 5:14 PM, Kris Borchers <span dir="ltr"><<a href="mailto:kris@redhat.com" target="_blank">kris@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div>
<div>On Jul 17, 2013, at 4:37 AM, Matthias Wessendorf <<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">Hi,<div><br></div><div>in the message spec discussions, a while ago, we agreed that for "triggering" notifications for registered SimplePush clients, the "deviceType" needs to match "web" (see [1] for the spec).</div>
<div><br></div><div>Right now, only a few "metadata" items are submitted to the UnifiedPush Server, using the "registerWithPushServer" (perhaps we should rename it ?):</div><div><a href="https://github.com/aerogear/aerogear-js/blob/Notifier/src/unified-push/aerogear.unifiedpush.js#L48-L52" target="_blank">https://github.com/aerogear/aerogear-js/blob/Notifier/src/unified-push/aerogear.unifiedpush.js#L48-L52</a><br>
</div><div><br></div><div>However, I have already filed a ticket for that (see [2]), since on Cordova (and similar things) a bit more "metadata" would be nice (since they are really treated as "native" clients, with APNs/GCM setup on the UP server etc)</div>
<div><br></div><div><br></div><div>Now... talking about metadata (including the "deviceType"). The above statement, that the "deviceType" needs to match "web" for SimplePush clients leads to a question:</div>
<div><br></div><div>* Do we want to have ALL SimplePush clients auto-submit the "deviceType":"web", or not ? <br></div></div></blockquote><div><br></div></div>So deviceType is required no matter what it's set to, correct?</div>
</div></blockquote><div><br></div><div>No, we could have the SimplePush clients NOT submitting the "deviceType" value at all (like today).</div><div><br></div><div><br></div><div>It would be just used, on the sective send, a logical query on the 'selective' send.</div>
<div><br></div><div>So:</div><div>If "deviceType:["web",.......] is present in the payload - SimplePush is triggered as well. That is fine.</div><div><br></div><div>right now, I did assume that we want to "auto register" the 'web' device-type for the SP clients, but I can easily remove that assumption. </div>
</div></div></div></blockquote><div><br></div></div>Well, I didn't realize you made that assumption so that is why the client isn't currently working with latest UPS. I guess I don't care either way let's just decide what we'll do so I can either update the client or leave it as is. Until then, it's broken.</div>
</div></blockquote><div><br></div><div><br></div><div><a href="https://github.com/aerogear/aerogear-unified-push-server/commit/7c0ad459d" target="_blank">https://github.com/aerogear/aerogear-unified-push-server/commit/7c0ad459d</a><br>
</div>
<div><br></div><div>As discussed on IRC, I did remove this assumption, for simple push clients.</div><div><br></div><div>However, for Cordova clients, there should be an option to provide other metadata for deviceType, but we already have a ticket for that:</div>
<div><br></div><div><br></div><div><a href="https://issues.jboss.org/browse/AGJS-56">https://issues.jboss.org/browse/AGJS-56</a><br></div>
<div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><div><br><blockquote type="cite"><div dir="ltr"><div><br></div><div>If NOT, I guess that means there will be NO deviceType for SimplePush clients, on the UnifiedPush server, which is fine.</div></div></blockquote>
<blockquote type="cite"><div dir="ltr">
<div><br></div><div>But once more metadata is possible (e.g. after AGJS-56), I think we than need to ensure that a SP client does not set it's deviceType to something like "winBROwsPhone" :)</div></div></blockquote>
<div><br></div></div>Hmmm. I could see a situation where users may want this setting to be flexible for tracking. </div></div></blockquote><div><br></div><div>For the "Apache Cordova" with native (GCM and APNs) bits, IMO it may make sense to have a similar rich "registration" API, like the matching native environments have.<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div>
They may want "web-iOS" if they are using SimplePush in a iOS-Cordova app.</div>
</div></blockquote><div><br></div><div><br></div><div><br></div><div>For SimplePush on Cordova, I think it does make sense, if they have an option to 'specify' some (custom) device-type as well</div><div><br></div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="word-wrap:break-word"><div> Not sure. So to answer above, I think there should either be no device type, or if there is, let it be flexible.<br>
<blockquote type="cite"><div><div dir="ltr"><div><br></div>
<div><br></div><div>-Matthias</div><div><br></div><div><br></div><div>[1] <a href="https://github.com/aerogear/aerogear.org/blob/master/docs/specs/aerogear-push-messages/index.markdown#query-component" target="_blank">https://github.com/aerogear/aerogear.org/blob/master/docs/specs/aerogear-push-messages/index.markdown#query-component</a><br clear="all">
<div>[2] <a href="https://issues.jboss.org/browse/AGJS-56" target="_blank">https://issues.jboss.org/browse/AGJS-56</a></div><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div></div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote>
</div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></blockquote>
</div></div></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>