<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 23, 2013 at 4:19 PM, Summers Pittman <span dir="ltr"><<a href="mailto:supittma@redhat.com" target="_blank">supittma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div class="im">
<div>On 07/23/2013 05:17 AM, Matthias
Wessendorf wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hello,
<div><br>
</div>
<div>I have a few question on the 'push' branch:</div>
<div><br>
</div>
<div>1) going over the MessageHandler interface ([1]), am I
right that the "onError()" and "onDeleteMessage()" methods are
only relevant for the "device to cloud" case ?</div>
</div>
</blockquote></div>
Not exactly. These are handlers for status messages from GCM.
onDeleteMessage is sent to the client when a notification has been
removed from the server. This can be because they notifications are
being batched for instance.<br>
See the GcmBroadcastReceiver sample code for details:
<a href="https://developer.android.com/google/gcm/gs.html" target="_blank">https://developer.android.com/google/gcm/gs.html</a><br>
<br>
And the
javadocs:<a href="https://developer.android.com/reference/com/google/android/gms/gcm/GoogleCloudMessaging.html#MESSAGE_TYPE_DELETED" target="_blank">https://developer.android.com/reference/com/google/android/gms/gcm/GoogleCloudMessaging.html#MESSAGE_TYPE_DELETED</a><br>
<br>
As far as the error message handler goes, the docs aren't explicit,
but I think I misread it and you are correct. It is a callback for
when an error on the server happens receiving a message from the
client.<div class="im"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<br>
</div>
<div>2) I know it's early work, but I was wondering if we
should (later) rename the 'AGPushMessageReceiver' class
([2]).</div>
<div><br>
</div>
</div>
</div>
</blockquote></div>
+1 to a rename. <br><div class="im">
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Not sure on a better name, but the AG prefix seems a
little odd :) Perhaps:</div>
<div>
<div>* PushMessageReceiver</div>
</div>
<div>
<div>* AeroGearPushMessageReceiver</div>
</div>
<div>
<div>* GCMMessageReceiver (since this is really "only" GCM
based push messaging)</div>
</div>
<div>* AeroGearGCMMessageReceiver</div>
</div>
</div>
</blockquote></div>
I like this one.</div></blockquote><div><br></div><div>based on this thread, I submitted this PR:</div><div><a href="https://github.com/aerogear/aerogear-android/pull/88">https://github.com/aerogear/aerogear-android/pull/88</a><br>
</div><div><br></div><div>-Matthias</div><div><br></div><div><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div class="im"><br>
<blockquote type="cite">
<div dir="ltr">
<div>
<div><br>
</div>
<div>If folks agree on a later rename, I'd create a JIRA to
track this ;-)</div>
</div>
</div>
</blockquote>
<br>
</div><blockquote type="cite"><div class="im">
<div dir="ltr">
<div>
<div><br>
</div>
<div><br>
</div>
<div>Greetings,</div>
<div>Matthias</div>
<div><br>
</div>
<div>[1] <a href="https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/MessageHandler.java" target="_blank">https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/MessageHandler.java</a></div>
<div>[2] <a href="https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/AGPushMessageReceiver.java" target="_blank">https://github.com/aerogear/aerogear-android/blob/push/src/org/jboss/aerogear/android/unifiedpush/AGPushMessageReceiver.java</a><br clear="all">
<div><br>
</div>
-- <br>
Matthias Wessendorf <br>
<br>
blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div><pre>_______________________________________________
aerogear-dev mailing list
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></pre>
</blockquote>
<br>
</div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>