<div dir="ltr">One question that I have is: does it work if the server is connected on https ? <div><br></div><div>Asking because of [1]</div><div><div><br></div><div>-M</div></div><div><br></div><div>[1] <a href="https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/pull/1">https://github.com/aerogear/aerogear-unifiedpush-nodejs-client/pull/1</a></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 21, 2013 at 10:55 AM, Karel Piwko <span dir="ltr">&lt;<a href="mailto:kpiwko@redhat.com" target="_blank">kpiwko@redhat.com</a>&gt;</span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">First review of PHP code available, kudos to Yaniv (in CC).<br>
<br>
Pasting response:<br>
<br>
Karel,<br>
sorry for not replying in the <a href="http://github.com" target="_blank">github.com</a> but those are more informal code<br>
changes that you can use.<br>
<br>
its been so few year since i&#39;ve last touched PHP but while i was there i used<br>
to work with global registers for session. at the top of each php page verify<br>
that your session is still valid, it is also good for security so people will<br>
not login to the page directly.<br>
<br>
if($user_id==0 || $user_id==Null){<br>
        die(&#39;Time out - please login again&#39;);<br>
        Exit;<br>
}<br>
<br>
<br>
<br>
<br>
another thing you can use is the &quot;$$&quot; which will create a var at the same name.<br>
<br>
<br>
<br>
foreach($_POST as $key=&gt;$value){<br>
        $$key=addslashes($value);<br>
        $form_vars[&quot;$key&quot;]=$value;<br>
}<br>
foreach($_GET as $key=&gt;$value){<br>
        $$key=addslashes($value);<br>
        $form_vars[&quot;$key&quot;]=$value;<br>
<div class="HOEnZb"><div class="h5">}<br>
<br>
On Tue, 20 Aug 2013 13:59:51 -0400 (EDT)<br>
Tommy McCarthy &lt;<a href="mailto:tomccart@redhat.com">tomccart@redhat.com</a>&gt; wrote:<br>
<br>
&gt; Hey everyone,<br>
&gt; I&#39;m at the point now where I believe my PHP SDK code is complete and ready to<br>
&gt; be reviewed and tested. Of course, if anyone has any feedback for it so far,<br>
&gt; that would be appreciated as well. The GitHub repo is available here [1].<br>
&gt; I&#39;ve created a JIRA [2] for creating a GitHub repo for the PHP code under the<br>
&gt; AeroGear account.<br>
&gt;<br>
&gt; If there&#39;s anything you&#39;d like to see added, changed, or removed, please let<br>
&gt; me know! There is a webapp included as a part, which demonstrates a great way<br>
&gt; to send messages from a web form (or other request)<br>
&gt;<br>
&gt; Thanks!<br>
&gt; Tommy<br>
&gt;<br>
&gt; [1] <a href="https://github.com/tmccarthy9/aerogear-unified-push-php-client" target="_blank">https://github.com/tmccarthy9/aerogear-unified-push-php-client</a><br>
&gt; [2] <a href="https://issues.jboss.org/browse/AEROGEAR-1312" target="_blank">https://issues.jboss.org/browse/AEROGEAR-1312</a><br>
&gt; _______________________________________________<br>
&gt; aerogear-dev mailing list<br>
&gt; <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
&gt; <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>