<div dir="ltr">Hi Tommy,<div><br></div><div>if the scheme/protocol is "https" (or "https:"), I think the following snippet:</div><div><br></div><div>curl_setopt($con, CURLOPT_SSLVERSION, 3);</div><div><br>
</div><div>is needed in here:</div><div><a href="https://github.com/tmccarthy9/aerogear-unified-push-php-client/blob/master/src/SenderClient.php#L74-L80">https://github.com/tmccarthy9/aerogear-unified-push-php-client/blob/master/src/SenderClient.php#L74-L80</a><br>
</div><div><br></div><div><br></div><div>-Matthias</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 21, 2013 at 9:02 PM, Tommy McCarthy <span dir="ltr"><<a href="mailto:tomccart@redhat.com" target="_blank">tomccart@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">For Matthias, I'm looking into the SSL issue now. Currently it only works over HTTP. I'm looking into my options with that now, and have found a few, but still need to work them into my code properly. I'll keep the list updated when I get something.<br>
<br>
As for the register_globals concerns, they have been deprecated since PHP 5.3, and completely removed since 5.4.0. [1] Most servers have register_globals off nowadays.<br>
<br>
[1] <a href="http://php.net/manual/en/security.globals.php" target="_blank">http://php.net/manual/en/security.globals.php</a><br>
<div class="HOEnZb"><div class="h5"><br>
----- Original Message -----<br>
From: "Karel Piwko" <<a href="mailto:kpiwko@redhat.com">kpiwko@redhat.com</a>><br>
To: <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>, <a href="mailto:yeylon@redhat.com">yeylon@redhat.com</a><br>
Sent: Wednesday, August 21, 2013 4:55:06 AM<br>
Subject: Re: [aerogear-dev] PHP SDK<br>
<br>
First review of PHP code available, kudos to Yaniv (in CC).<br>
<br>
Pasting response:<br>
<br>
Karel,<br>
sorry for not replying in the <a href="http://github.com" target="_blank">github.com</a> but those are more informal code<br>
changes that you can use.<br>
<br>
its been so few year since i've last touched PHP but while i was there i used<br>
to work with global registers for session. at the top of each php page verify<br>
that your session is still valid, it is also good for security so people will<br>
not login to the page directly.<br>
<br>
if($user_id==0 || $user_id==Null){<br>
die('Time out - please login again');<br>
Exit;<br>
}<br>
<br>
<br>
<br>
<br>
another thing you can use is the "$$" which will create a var at the same name.<br>
<br>
<br>
<br>
foreach($_POST as $key=>$value){<br>
$$key=addslashes($value);<br>
$form_vars["$key"]=$value;<br>
}<br>
foreach($_GET as $key=>$value){<br>
$$key=addslashes($value);<br>
$form_vars["$key"]=$value;<br>
}<br>
<br>
On Tue, 20 Aug 2013 13:59:51 -0400 (EDT)<br>
Tommy McCarthy <<a href="mailto:tomccart@redhat.com">tomccart@redhat.com</a>> wrote:<br>
<br>
> Hey everyone,<br>
> I'm at the point now where I believe my PHP SDK code is complete and ready to<br>
> be reviewed and tested. Of course, if anyone has any feedback for it so far,<br>
> that would be appreciated as well. The GitHub repo is available here [1].<br>
> I've created a JIRA [2] for creating a GitHub repo for the PHP code under the<br>
> AeroGear account.<br>
><br>
> If there's anything you'd like to see added, changed, or removed, please let<br>
> me know! There is a webapp included as a part, which demonstrates a great way<br>
> to send messages from a web form (or other request)<br>
><br>
> Thanks!<br>
> Tommy<br>
><br>
> [1] <a href="https://github.com/tmccarthy9/aerogear-unified-push-php-client" target="_blank">https://github.com/tmccarthy9/aerogear-unified-push-php-client</a><br>
> [2] <a href="https://issues.jboss.org/browse/AEROGEAR-1312" target="_blank">https://issues.jboss.org/browse/AEROGEAR-1312</a><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>