<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 12, 2013 at 3:00 PM, Bruno Oliveira <span dir="ltr"><<a href="mailto:bruno@abstractj.org" target="_blank">bruno@abstractj.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From my humble perspective there are 2 alternatives:<br>
<br>
- Be conscious about what you are doing that means (what I'm sending on<br>
this PR, instead of git commit -a)<br></blockquote><div><br></div><div>yep, that's what I meant. formatting on file that are touched -> mostly fine;</div><div>git commit -a and adding 100000000 unrelated files -> DOH ! :)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Add a baby sitting service like checkstyle and make the build fail :)<br></blockquote><div><br></div><div>I don't mind check-style on the build</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
> Matthias Wessendorf <mailto:<a href="mailto:matzew@apache.org">matzew@apache.org</a>><br>
> September 12, 2013 9:49 AM<br>
<div class="im">><br>
><br>
><br>
> On Thu, Sep 12, 2013 at 2:44 PM, Lucas Holmquist <<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a><br>
</div><div class="im">> <mailto:<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a>>> wrote:<br>
><br>
><br>
> On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <<a href="mailto:bruno@abstractj.org">bruno@abstractj.org</a><br>
</div><div class="im">> <mailto:<a href="mailto:bruno@abstractj.org">bruno@abstractj.org</a>>> wrote:<br>
><br>
> > Guys, just run mvn java-formatter:formatbefore commit, we have it<br>
> > enabled at POM parent as far as I know.<br>
><br>
> yup, as long as we are doing it every time we do a PR.<br>
><br>
><br>
> The problem with adding a "fix formatting" commit in the _same_ PR<br>
> than "fix a real problem" is: Too much noise.<br>
><br>
> IMO it's just odd if 1000 files get formatted in one PR, which<br>
> actually is intended to include a one line (java) fix<br>
><br>
> -M<br>
><br>
><br>
><br>
><br>
> but when it's on a mature code base that hasn't had it before and<br>
> mixed with other changes, then things get hairy<br>
><br>
> ><br>
> >> Lucas Holmquist <mailto:<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a><br>
> <mailto:<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a>>><br>
> >> September 12, 2013 9:31 AM<br>
> >> +1<br>
> >><br>
> >><br>
> >> _______________________________________________<br>
> >> aerogear-dev mailing list<br>
</div>> >> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> <mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>><br>
<div class="im">> >> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> >> Daniel Bevenius <mailto:<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a><br>
> <mailto:<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a>>><br>
> >> September 12, 2013 4:13 AM<br>
> >> #agreed<br>
> >><br>
> >><br>
> >><br>
> >> _______________________________________________<br>
> >> aerogear-dev mailing list<br>
</div>> >> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> <mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>><br>
<div class="im">> >> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> >> Matthias Wessendorf <mailto:<a href="mailto:matzew@apache.org">matzew@apache.org</a><br>
> <mailto:<a href="mailto:matzew@apache.org">matzew@apache.org</a>>><br>
> >> September 12, 2013 4:00 AM<br>
> >> Hi,<br>
> >><br>
> >> it's nice when we like to format code, however mixing that with<br>
> actual<br>
> >> fixes, makes it VERY hard to review the real change....<br>
> >><br>
> >> Please let's not mix these things; It's IMO annoying going over 100<br>
> >> files, when the real fix involves just 2 or 3 files....<br>
> >><br>
> >> -M<br>
> >><br>
> >> --<br>
> >> Matthias Wessendorf<br>
> >><br>
> >> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> >> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> >> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
> >> _______________________________________________<br>
> >> aerogear-dev mailing list<br>
</div>> >> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> <mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>><br>
<div class="im">> >> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> ><br>
> > --<br>
> > abstractj<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > aerogear-dev mailing list<br>
</div>> > <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> <mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>><br>
<div class="im">> > <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
</div>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a> <mailto:<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a>><br>
<div class="im">> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Matthias Wessendorf<br>
><br>
> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
</div><div class="im">> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div>> Lucas Holmquist <mailto:<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a>><br>
> September 12, 2013 9:44 AM<br>
<div class="im HOEnZb">> On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <<a href="mailto:bruno@abstractj.org">bruno@abstractj.org</a>> wrote:<br>
><br>
>> Guys, just run mvn java-formatter:formatbefore commit, we have it<br>
>> enabled at POM parent as far as I know.<br>
><br>
> yup, as long as we are doing it every time we do a PR.<br>
><br>
><br>
</div><div class="HOEnZb"><div class="h5">> but when it's on a mature code base that hasn't had it before and mixed with other changes, then things get hairy<br>
><br>
>>> Lucas Holmquist <mailto:<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a>><br>
>>> September 12, 2013 9:31 AM<br>
>>> +1<br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> aerogear-dev mailing list<br>
>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
>>> Daniel Bevenius <mailto:<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a>><br>
>>> September 12, 2013 4:13 AM<br>
>>> #agreed<br>
>>><br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> aerogear-dev mailing list<br>
>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
>>> Matthias Wessendorf <mailto:<a href="mailto:matzew@apache.org">matzew@apache.org</a>><br>
>>> September 12, 2013 4:00 AM<br>
>>> Hi,<br>
>>><br>
>>> it's nice when we like to format code, however mixing that with actual<br>
>>> fixes, makes it VERY hard to review the real change....<br>
>>><br>
>>> Please let's not mix these things; It's IMO annoying going over 100<br>
>>> files, when the real fix involves just 2 or 3 files....<br>
>>><br>
>>> -M<br>
>>><br>
>>> --<br>
>>> Matthias Wessendorf<br>
>>><br>
>>> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
>>> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
>>> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
>>> _______________________________________________<br>
>>> aerogear-dev mailing list<br>
>>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
>> --<br>
>> abstractj<br>
>><br>
>><br>
>> _______________________________________________<br>
>> aerogear-dev mailing list<br>
>> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> Lucas Holmquist <mailto:<a href="mailto:lholmqui@redhat.com">lholmqui@redhat.com</a>><br>
> September 12, 2013 9:31 AM<br>
> +1<br>
><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> Daniel Bevenius <mailto:<a href="mailto:daniel.bevenius@gmail.com">daniel.bevenius@gmail.com</a>><br>
> September 12, 2013 4:13 AM<br>
> #agreed<br>
><br>
><br>
><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> Matthias Wessendorf <mailto:<a href="mailto:matzew@apache.org">matzew@apache.org</a>><br>
> September 12, 2013 4:00 AM<br>
> Hi,<br>
><br>
> it's nice when we like to format code, however mixing that with actual<br>
> fixes, makes it VERY hard to review the real change....<br>
><br>
> Please let's not mix these things; It's IMO annoying going over 100<br>
> files, when the real fix involves just 2 or 3 files....<br>
><br>
> -M<br>
><br>
> --<br>
> Matthias Wessendorf<br>
><br>
> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
--<br>
abstractj<br>
<br>
<br>
</div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>