<div dir="ltr">I tend to use #3 or #4 </div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Sep 17, 2013 at 11:19 AM, Corinne Krych <span dir="ltr"><<a href="mailto:corinnekrych@gmail.com" target="_blank">corinnekrych@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I've praticed #3 when working with iOS fellows. At least it keeps an ownership of the PR. But it might be a case by case choice depending on what is more efficient.<br>
<br>
++<br>
Corinne<br>
<div><div class="h5">On Sep 17, 2013, at 11:14 AM, Sebastien Blanc <<a href="mailto:scm.blanc@gmail.com">scm.blanc@gmail.com</a>> wrote:<br>
<br>
> Hi,<br>
> I was wondering what was the common/best practice when you want to contribute (with commits) to an existing PR (assuming you have no commit rights on the branch where the PR comes from) :<br>
><br>
> - Commits on the PR is only the responsability of the one who created it, he has to report the fixes.<br>
><br>
> - The "fixer" forks the PR branch, fix it, close the old PR and resubmit a new PR<br>
><br>
> - The "fixer" forks the PR branch, fix it and submit a PR to the branch from the original PR (this way after the merge, the existing PR will be updated)<br>
><br>
> - For big PRs where other team members are likely to submits commits make sure to submit a PR from the aerogear repo ? (but this just counts for team members)<br>
><br>
> Thx for you input !<br>
><br>
> Seb<br>
><br>
</div></div>> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br><br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>