<div dir="ltr">+1<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 10:16 AM, Karel Piwko <span dir="ltr"><<a href="mailto:kpiwko@redhat.com" target="_blank">kpiwko@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1<br>
<div class="HOEnZb"><div class="h5"><br>
On Wed, 18 Sep 2013 07:40:58 -0500<br>
Kris Borchers <<a href="mailto:kris@redhat.com">kris@redhat.com</a>> wrote:<br>
<br>
> +1<br>
><br>
> On Sep 18, 2013, at 7:35 AM, Matthias Wessendorf <<a href="mailto:matzew@apache.org">matzew@apache.org</a>> wrote:<br>
><br>
> > No, it's more like<br>
> ><br>
> > * may not be null<br>
> > * is to long<br>
> ><br>
> > etc<br>
> ><br>
> > Not providing IDs, credentials etc. Makes sense ?<br>
> ><br>
> ><br>
> > On Wed, Sep 18, 2013 at 2:32 PM, Kris Borchers <<a href="mailto:kris@redhat.com">kris@redhat.com</a>> wrote:<br>
> > I will say +1 for this as long as none of the error messages returned<br>
> > introduce security issues by exposing too much info.<br>
> ><br>
> > On Sep 18, 2013, at 4:27 AM, Matthias Wessendorf <<a href="mailto:matzew@apache.org">matzew@apache.org</a>> wrote:<br>
> ><br>
> >> Following up on [1], currently we give 400 (Bad Request), with no good<br>
> >> meaning, when creating/updating a PushApplication or a Variant;<br>
> >><br>
> >><br>
> >> The HTML page(!) simply says "The request sent by the client was<br>
> >> syntactically incorrect "<br>
> >><br>
> >> As suggested in [1] a good idea is using Bean Validation and returning<br>
> >> better errors.<br>
> >><br>
> >> The result would be a 400 (Bad Request) response, containing the errors<br>
> >> and their messages as a JSON object (instead of a HTML page).<br>
> >><br>
> >> E.g.:<br>
> >><br>
> >> {"name":"may not be null"}<br>
> >><br>
> >> This is a) more meaningful and we can also get rid of our 'hard-coded'<br>
> >> validation rules, like:<br>
> >> <a href="https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AndroidVariantEndpoint.java#L79-L82" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AndroidVariantEndpoint.java#L79-L82</a><br>
> >><br>
> >> -Matthias<br>
> >><br>
> >><br>
> >> [1] <a href="https://issues.jboss.org/browse/AGPUSH-255" target="_blank">https://issues.jboss.org/browse/AGPUSH-255</a><br>
> >><br>
> >> --<br>
> >> Matthias Wessendorf<br>
> >><br>
> >> blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> >> sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> >> twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
> >> _______________________________________________<br>
> >> aerogear-dev mailing list<br>
> >> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> >> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > aerogear-dev mailing list<br>
> > <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> ><br>
> ><br>
> ><br>
> > --<br>
> > Matthias Wessendorf<br>
> ><br>
> > blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
> > sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
> > twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a><br>
> > _______________________________________________<br>
> > aerogear-dev mailing list<br>
> > <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
><br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br></div>