<div dir="ltr">You should also make sure that the licence header is present on the source files.<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 23, 2013 at 2:06 PM, Erik Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div class="im"><br><div><div>On 23 Sep,2013, at 14:02 , Kris Borchers <<a href="mailto:kris@redhat.com" target="_blank">kris@redhat.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="word-wrap:break-word"><br><div><div>On Sep 23, 2013, at 7:00 AM, Lucas Holmquist <<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>> wrote:</div><br>
<blockquote type="cite"><div style="word-wrap:break-word">one quick that stands out for me is the version number of the plugin, i don't think it should start at 1.0.0 , IMO it should be more like 0.0.1 or maybe a 0.1.0 <br>
</div></blockquote><div><br></div>+1</div></div></blockquote><div><br></div></div></div>Yep makes sense updated it to 0.0.1 and <a href="http://plugins.cordova.io/#/org.jboss.aerogear.cordova" target="_blank">published it</a></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>