<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/4.6.4">
</HEAD>
<BODY>
+ 1<BR>
<BR>
Personally, I like your implementation with the callbacks :) <BR>
<BR>
Regarding [1] I would prefer declaring and giving meaningful names in callback functions and then passing just the names, instead of passing anonymous functions. I think this way is more readable and makes JavaScript code cleaner.<BR>
<BR>
[1]: https://github.com/edewit/aerogear-otp-cordova/blob/master/example/js/index.js#L40<BR>
<BR>
<BR>
On Mon, 2013-09-23 at 08:38 +0200, Erik Jan de Wit wrote:
<BLOCKQUOTE TYPE=CITE>
<H2>
<B><FONT SIZE="5">One Time Password</FONT></B>
</H2>
I've checked in the <A HREF="https://github.com/edewit/aerogear-otp-cordova">cordova otp</A> module it now supports Android and iOS, I've added a dependency on the barcode scanner plugin so that it is a complete package. There is one general <TT>generate</TT> method that will check if there is a secret stored if not it will fire up the barcode scanner to scan a secret and then store it. There are also separate methods that support these functions.<BR>
<BR>
On the android side I use SharedPreferences and for iOS NSUserDefaults to store the secret. Currently the project is under my own name don't know how to move it.<BR>
<BR>
As this is a security thing it would be great if others would take a look at because we want to be extra sure there is no obvious security hole in this.<BR>
<BR>
Cheers, Erik Jan<BR>
<BR>
<PRE>
_______________________________________________
aerogear-dev mailing list
<A HREF="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</A>
<A HREF="https://lists.jboss.org/mailman/listinfo/aerogear-dev">https://lists.jboss.org/mailman/listinfo/aerogear-dev</A>
</PRE>
</BLOCKQUOTE>
<BR>
</BODY>
</HTML>