<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 29, 2013, at 8:23 AM, Sebastien Blanc <<a href="mailto:scm.blanc@gmail.com">scm.blanc@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 29, 2013 at 2:20 PM, Lucas Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div class="im"><div>On Oct 29, 2013, at 6:39 AM, Erik Jan de Wit <<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="word-wrap:break-word">Hi,<div><br></div><div>I saw that there was some discussion about whitespace in a javascript file on a PR yesterday. Now it seems to me that among the things to discuss whitespace is just noise, especially because formatting can be done automatically. </div>
</div></blockquote><div><br></div></div><div>I think part of this was the fact that somethings didn't need to be revisioned.( some IDE's like to do stuff ).</div><div><br></div><div> I think it is important as part of the commit process that we need to be making sure that we are only committing changes that we made.</div>
</div></div></blockquote><div><br></div><div style="">+1 and I take entirely responsibility for this one. Auto format from IDEs are evil. And running grunt without any warning should be a condition before pushing.</div></div></div></div></blockquote><div><br></div>Well, isn't that an implied condition?? You should always make sure the build passes before you send a PR or push any code.<br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style="">
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><br></div><div> </div><br><blockquote type="cite"><div class="im">
<div style="word-wrap:break-word"><div>Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this. </div><div><br></div><div>To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it:</div>
<div><br></div><div><a href="https://github.com/krasa/EclipseCodeFormatter" target="_blank">https://github.com/krasa/EclipseCodeFormatter</a></div><div><a href="https://code.google.com/p/maven-java-formatter-plugin" target="_blank">https://code.google.com/p/maven-java-formatter-plugin</a> </div>
<div><a href="http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/" target="_blank">http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/</a></div><div><br></div><div>So how about having something like this that will format our JS for us? We could integrate something like this in our build, or that or create our own CLI tool as long as we have something that will work so that we don't have to discuss formatting anymore, what do you think?</div>
<div><br></div><div>Cheers,</div><div><span style="white-space:pre-wrap"> </span>Erik Jan</div></div></div><div class="im">_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div></blockquote></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div></div>
_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>https://lists.jboss.org/mailman/listinfo/aerogear-dev</blockquote></div><br></body></html>