<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 29, 2013 at 11:39 AM, Erik Jan de Wit <span dir="ltr"><<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi,<div><br></div><div>I saw that there was some discussion about whitespace in a javascript file on a PR yesterday. Now it seems to me that among the things to discuss whitespace is just noise,</div>
</div></blockquote><div><br></div><div>+1 - especially the amount of comments</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">
<div> especially because formatting can be done automatically.</div></div></blockquote><div><br></div><div>Isn't it ? I did run 'grunt' on that PR and that tool was already crying about formating issues</div><div>
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div> Talking with qmx and lholmquist about this it seems that JS land doesn't have good tools for this. </div>
</div></blockquote><div><br></div><div><br></div><div>hrm - the grunt worked for me; but I don't know if it is _that_ good</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><br></div><div>To have something in the mean time we could use something like the eclipse formatter, because it can format JS has a ton of options and there are already a lot of external tools that use it:</div>
<div><br></div><div><a href="https://github.com/krasa/EclipseCodeFormatter" target="_blank">https://github.com/krasa/EclipseCodeFormatter</a></div></div></blockquote><div><br></div><div>I doubt that a JS weenie will use Eclipse/IDEA</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><a href="https://code.google.com/p/maven-java-formatter-plugin" target="_blank">https://code.google.com/p/maven-java-formatter-plugin</a> </div>
</div></blockquote><div><br></div><div>similar w/ maven, adding maven to a JS build is a bit.... </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><a href="http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/" target="_blank">http://liviutudor.com/2012/03/02/batch-source-formatting-in-eclipse-indigo/</a></div></div></blockquote><div><br></div>
<div>not sure about eclipse dependency;</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>So how about having something like this that will format our JS for us? We could integrate something like this in our build, or that or create our own CLI tool as long as we have something that will work so that we don't have to discuss formatting anymore, what do you think?</div>
</div></blockquote><div><br></div><div>Again, not sure if something like grunt does already help us.</div><div><br></div><div>-M</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><br></div><div>Cheers,</div><div><span style="white-space:pre-wrap"> </span>Erik Jan</div></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>