<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 19, 2013 at 2:35 PM, Lucas Holmquist <span dir="ltr"><<a href="mailto:lholmqui@redhat.com" target="_blank">lholmqui@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div class="im"><div>On Nov 19, 2013, at 4:21 AM, Erik Jan de Wit <<a href="mailto:edewit@redhat.com" target="_blank">edewit@redhat.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="word-wrap:break-word">Hi,<div><br></div><div>Last tuesday the PR for the new javascript crypto api landed, because I developed the crypto cordova plugin based on the 'old' api there is now a discrepancy between the 'current' javascript crypto api and the cordova one. We could change that this week as there aren't that many people that use the crypto cordova plugin, but we have frozen so what is the point of a freeze when we change things regardless?</div>
<div><br></div></div></blockquote></div><div>If it is still in your repo and not an AeroGear one, then i think it is fine to change.</div><div><br></div><div>Since the code freeze was on friday, and the change was made on the tuesday before, i'm thinking that should've been enough time to update. I don't believe the change was to big</div>
</div></div></blockquote><div><br></div><div>I agree w/ Erik that updating the Cordova items is not on the same page of updating a drop-in JS file, hence I think it's reasonable to change that now and simply release the Cordova bits a bit later than all the other items (Android, iOS and JS)</div>
<div><br></div><div>-Matthias </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><br></div><br>
<blockquote type="cite"><div class="im"><div style="word-wrap:break-word"><div>Anyway I think we could still change this what do you think?</div><div><br></div><div>Cheers,</div><div><span style="white-space:pre-wrap"> </span>Erik Jan</div>
<div><br></div><div>p.s.</div><div>have a look at the differences:</div><div><br></div><div>current javascript api</div><div><a href="https://github.com/aerogear/aerogear-js/blob/master/tests/unit/crypto/aerogear.crypto.js" target="_blank">https://github.com/aerogear/aerogear-js/blob/master/tests/unit/crypto/aerogear.crypto.js</a></div>
<div><br></div><div>current cordova api</div><div><a href="https://github.com/edewit/aerogear.org/blob/f2fe8a48b2f9d9c581e62292abeaf788c0c4338e/docs/guides/aerogear-cordova/AerogearCordovaCrypto.asciidoc" target="_blank">https://github.com/edewit/aerogear.org/blob/f2fe8a48b2f9d9c581e62292abeaf788c0c4338e/docs/guides/aerogear-cordova/AerogearCordovaCrypto.asciidoc</a></div>
</div></div><div class="im">_______________________________________________<br>aerogear-dev mailing list<br><a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></div>
</blockquote></div><br></div><br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div>