<div dir="ltr">Thanks guys!<div>I've got my answers.</div><div><br></div><div>I agree with you, I'll keep Pipe under the hood but I will define a new protocol as you said 'save' method has 3 callbacks: success, failure conflict using Pipe protocol feels awkward somehow.</div>
<div>I'll update ios-sync repo with a new proposal and i'll share it with you shortly so we can discuss further.</div><div><br></div><div>Once we agree on API we can define spec.</div><div><br></div><div>++</div>
<div>Corinne</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 4 February 2014 18:14, Matthias Wessendorf <span dir="ltr"><<a href="mailto:matzew@apache.org" target="_blank">matzew@apache.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Tue, Feb 4, 2014 at 6:10 PM, Summers Pittman <span dir="ltr"><<a href="mailto:supittma@redhat.com" target="_blank">supittma@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div>
<div>On 02/04/2014 11:52 AM, Matthias
Wessendorf wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Tue, Feb 4, 2014 at 5:42 PM,
Summers Pittman <span dir="ltr"><<a href="mailto:supittma@redhat.com" target="_blank">supittma@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div>On 02/04/2014 03:04 AM, Corinne Krych
wrote:<br>
> Hello all,<br>
><br>
> I started doing demo app Buddies and Hobbies [1]
(same idea than luke’s one [2]). But instead of usin
gcomplete separate chanel I wrapped Pipe within SyncPipe
[3]. Questions:<br>
> 1. looking at Luke’s work I didn’t see the usage of
pipe at all.<br>
> 2. do we want to reuse Pipe protocol/interface for
sync Pipe or use a different one?<br>
> I rather use the pipe underneath as we don’t want
to reimplement Paging, upload etc...<br>
> wdyt guys?<br>
</div>
I don't think extending Pipe is the best idea. However, I
feel that any<br>
synchronizer should use pipes under the hood.<br>
</blockquote>
<div><br>
</div>
<div>+1 </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
Think composition over inheritance. Also overloading the
read and save<br>
methods will get rather rough when we also have to check
for conflicts<br>
and handle responses from the server.<br>
</blockquote>
<div><br>
</div>
<div>+1</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
A SyncPipe could be the implementation the sync system
works in iOS, </blockquote>
<div><br>
</div>
<div>not sure I get this<br>
</div>
</div>
</div>
</div>
</blockquote></div>
Sorry was a merge error on my part when I was writing the email.<br>
<br>
I meant that there isn't anything wrong with making a sync pipe for
making implementing sync on iOS easier. I just don't think it
should be part of the platform.</div></blockquote><div><br></div></div><div>Ah! ok :-) </div><div><br></div><div>At least it sounds like a good idea to leverage the pipes internally, instead of making a AGSyncPipe</div>
<div><div class="h5"><div>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div><div><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">but<br>
I don't think it should be part of the spec/protocol.<br>
<div>
<div><br>
<br>
><br>
> With our actual server [4], we need adjust to
serve REST endpoint. Ugly harcoded it (for now) to
serve my purpose.<br>
><br>
> ++<br>
> Corinne<br>
> [1] <a href="https://github.com/corinnekrych/aerogear-ios-cookbook/tree/sync.demo.recipe/Hobbies" target="_blank">https://github.com/corinnekrych/aerogear-ios-cookbook/tree/sync.demo.recipe/Hobbies</a><br>
> [2] <a href="https://github.com/lholmquist/ag-js-ds-poc" target="_blank">https://github.com/lholmquist/ag-js-ds-poc</a><br>
> [3] <a href="https://github.com/corinnekrych/aerogear-sync-ios" target="_blank">https://github.com/corinnekrych/aerogear-sync-ios</a><br>
> [4] <a href="https://github.com/corinnekrych/aerogear-sync-server/blob/master/server/src/main/java/org/jboss/aerogear/sync/rest/RestChannelHandler.java#L49" target="_blank">https://github.com/corinnekrych/aerogear-sync-server/blob/master/server/src/main/java/org/jboss/aerogear/sync/rest/RestChannelHandler.java#L49</a><br>
> _______________________________________________<br>
> aerogear-dev mailing list<br>
> <a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Matthias Wessendorf <br>
<br>
blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>
sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
aerogear-dev mailing list
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a></pre>
</blockquote>
<br>
</div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org" target="_blank">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div></div></div><div><div class="h5"><br><br clear="all"><div><br>
</div>-- <br>Matthias Wessendorf <br>
<br>blog: <a href="http://matthiaswessendorf.wordpress.com/" target="_blank">http://matthiaswessendorf.wordpress.com/</a><br>sessions: <a href="http://www.slideshare.net/mwessendorf" target="_blank">http://www.slideshare.net/mwessendorf</a><br>
twitter: <a href="http://twitter.com/mwessendorf" target="_blank">http://twitter.com/mwessendorf</a>
</div></div></div></div>
<br>_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br></blockquote></div><br></div>