<div dir="ltr"><div><div>Sure, I'll try to improve the tests after refactoring the existing code and performing some changes that Bruno recommended.<br><br></div>Thanks,<br></div>Tolis<br><div class="gmail_extra"><br><br>
<div class="gmail_quote">2014-03-18 10:26 GMT+02:00 Karel Piwko <span dir="ltr"><<a href="mailto:kpiwko@redhat.com" target="_blank">kpiwko@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks Tolis, it looks good! We'd just need an additional test to verify<br>
previous behavior is still valid, e.g. connection test was rewritten, it should<br>
have been added next to http.<br>
<br>
Many thanks!<br>
<span class="HOEnZb"><font color="#888888"><br>
Karel<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Mon, 17 Mar 2014 21:59:22 +0200<br>
tolis emmanouilidis <<a href="mailto:tolisemm@gmail.com">tolisemm@gmail.com</a>> wrote:<br>
<br>
> To follow up, the JIRA id is AGPUSH-559 and I've sent a PR for supporting<br>
> custom truststores [1]. The integration tests using SSL and the custom<br>
> aerogear.truststore passed.<br>
><br>
> [1]: <a href="https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/36" target="_blank">https://github.com/aerogear/aerogear-unifiedpush-java-client/pull/36</a><br>
><br>
> Thanks,<br>
> Tolis<br>
><br>
><br>
> 2014-03-10 20:50 GMT+02:00 Matthias Wessendorf <<a href="mailto:matzew@apache.org">matzew@apache.org</a>>:<br>
><br>
> ><br>
> ><br>
> > On Monday, March 10, 2014, Bruno Oliveira <<a href="mailto:bruno@abstractj.org">bruno@abstractj.org</a>> wrote:<br>
> ><br>
> >> JIRA is enough as far as I can tell.<br>
> ><br>
> ><br>
> > +1 on JIRA for tracking<br>
> ><br>
> > feel free to send PR as well<br>
> ><br>
> > Greetings,<br>
> > Matthias<br>
> ><br>
> ><br>
> >><br>
> >> --<br>
> >> abstractj<br>
> >><br>
> >> On March 10, 2014 at 11:53:53 AM, Stefan Miklosovic (<a href="mailto:smikloso@redhat.com">smikloso@redhat.com</a>)<br>
> >> wrote:<br>
> >> > > Hi,<br>
> >> ><br>
> >> > so whats the "conclusion" for this? I would like to move forward<br>
> >> > with other things. Is JIRA to track this sufficient?<br>
> >> ><br>
> >> > Stefan Miklosovic<br>
> >> > Red Hat Brno - JBoss Mobile Platform<br>
> >><br>
> >> _______________________________________________<br>
> >> aerogear-dev mailing list<br>
> >> <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> >> <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> >><br>
> ><br>
> ><br>
> > --<br>
> > Sent from Gmail Mobile<br>
> ><br>
> > _______________________________________________<br>
> > aerogear-dev mailing list<br>
> > <a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
> ><br>
<br>
_______________________________________________<br>
aerogear-dev mailing list<br>
<a href="mailto:aerogear-dev@lists.jboss.org">aerogear-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/aerogear-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/aerogear-dev</a><br>
</div></div></blockquote></div><br></div></div>